From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E94FC76186 for ; Tue, 30 Jul 2019 02:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 757A42064C for ; Tue, 30 Jul 2019 02:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V/KPPgBl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731158AbfG3CQF (ORCPT ); Mon, 29 Jul 2019 22:16:05 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:40115 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730514AbfG3CQD (ORCPT ); Mon, 29 Jul 2019 22:16:03 -0400 Received: by mail-pg1-f193.google.com with SMTP id w10so29202615pgj.7; Mon, 29 Jul 2019 19:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MHeqW4XGwRZCSnKm2FHh/NR+ei+oiNfLETPiRLzlp1c=; b=V/KPPgBlV0awF1PGIW53YT1rmjWx6JGJT49TDhUesas9BTCDfXAFGbaByyw1eysAg9 bvgRA4v6ypGKIo0529BdCFOokDNe44HsdOzhKZbKpI1loiaO+OXZ2FGzboLDqiLHAqaP htyfb9lXsNO6yKRTRS0fla9Xcw4fUe2bLnnJZ4bRgUG/kK67TrAwzDO4ugjZcjo6djxf w652shW/X8lqhpDMynPlJn3HwKYBbNqU4+4syN56g/z3EHwHEdjJsOnp9F3nmiAQgIlZ 6paOdBwGnmmusP/mQ0KVKrahVkMrGtvYpZE9EdrnrWUAbOPb/ViHuDXwidFLt5tnA4xf stFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MHeqW4XGwRZCSnKm2FHh/NR+ei+oiNfLETPiRLzlp1c=; b=rCTmb24iNyH8jIx6CIWXGt0HjUJmCwbrEZxLTEKH/jtLQMvHZyrarRC2VJYFfz/VGd g0BYbdrzZasLbLkiYuEv87gdZKvgBzEtviUFRznf+6B9JhYyIKn/h/D9/wUdECbyRu1k pC2WX7jFM+fWQreb0WvflHrKsxyUR770mJOynsYgvxNmbu2rFC54KEvv4dg4CKzwkhpE FoNnXaY4lvcVuF433Frut6e2tFhNrGw/6eAoddt+APRG/6vJYmKt54t/fERzGiHAr/px B9YPH+mShQVmXr6n6Xappx0rgZJU5BMoHGg8de63EFMWekeSxL2YG2ThNMPjmNadk9vO BqoA== X-Gm-Message-State: APjAAAVqQOy9JbEycHElNPctxMaui0rrtm9zP+Haa9Z1I/qvtaaBFbFP KQSaS8FU7kJXH/ARWZFXS1hB0unkBbM= X-Google-Smtp-Source: APXvYqx1bBxZ/jXNVCAOPkCVavGQjQT13ZBFslgUVFldlrj6KG2cOOROfNX0tY3q4U6uIISjMgrhgw== X-Received: by 2002:a63:31cc:: with SMTP id x195mr95473353pgx.147.1564452962012; Mon, 29 Jul 2019 19:16:02 -0700 (PDT) Received: from localhost.localdomain ([203.205.141.123]) by smtp.googlemail.com with ESMTPSA id i7sm49836240pjk.24.2019.07.29.19.15.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Jul 2019 19:16:01 -0700 (PDT) From: Wanpeng Li X-Google-Original-From: Wanpeng Li To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= , Thomas Gleixner , Sean Christopherson , Nadav Amit Subject: [PATCH v2] KVM: X86: Use IPI shorthands in kvm guest when support Date: Tue, 30 Jul 2019 10:15:45 +0800 Message-Id: <1564452945-18425-1-git-send-email-wanpengli@tencent.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Wanpeng Li IPI shorthand is supported now by linux apic/x2apic driver, switch to IPI shorthand for all excluding self and all including self destination shorthand in kvm guest, to avoid splitting the target mask into several PV IPI hypercalls. This patch removes the kvm_send_ipi_all() and kvm_send_ipi_allbutself() since the callers in APIC codes have already taken care of apic_use_ipi_shorthand and fallback to ->send_IPI_mask and ->send_IPI_mask_allbutself if it is false. Cc: Thomas Gleixner Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Sean Christopherson Cc: Nadav Amit Signed-off-by: Wanpeng Li --- Note: rebase against tip tree's x86/apic branch v1 -> v2: * remove kvm_send_ipi_all() and kvm_send_ipi_allbutself() arch/x86/kernel/kvm.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index b7f34fe..96626d8 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -505,16 +505,6 @@ static void kvm_send_ipi_mask_allbutself(const struct cpumask *mask, int vector) __send_ipi_mask(local_mask, vector); } -static void kvm_send_ipi_allbutself(int vector) -{ - kvm_send_ipi_mask_allbutself(cpu_online_mask, vector); -} - -static void kvm_send_ipi_all(int vector) -{ - __send_ipi_mask(cpu_online_mask, vector); -} - /* * Set the IPI entry points */ @@ -522,8 +512,6 @@ static void kvm_setup_pv_ipi(void) { apic->send_IPI_mask = kvm_send_ipi_mask; apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself; - apic->send_IPI_allbutself = kvm_send_ipi_allbutself; - apic->send_IPI_all = kvm_send_ipi_all; pr_info("KVM setup pv IPIs\n"); } -- 2.7.4