From: no-reply@patchew.org
To: catherine.hecx@gmail.com
Cc: pbonzini@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, catherine.hecx@gmail.com,
ehabkost@redhat.com, kvm@vger.kernel.org, rth@twiddle.net
Subject: Re: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0
Date: Fri, 6 Dec 2019 15:48:57 -0800 (PST) [thread overview]
Message-ID: <157567613553.744.12283750572800820793@37313f22b938> (raw)
In-Reply-To: <1575627817-24625-1-git-send-email-catherine.hecx@gmail.com>
Patchew URL: https://patchew.org/QEMU/1575627817-24625-1-git-send-email-catherine.hecx@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0
Type: series
Message-id: 1575627817-24625-1-git-send-email-catherine.hecx@gmail.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
987441f target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0
=== OUTPUT BEGIN ===
ERROR: code indent should never use tabs
#38: FILE: target/i386/kvm.c:2637:
+^I/* Only add the entry when host supports it */$
total: 1 errors, 0 warnings, 14 lines checked
Commit 987441f7424c (target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1575627817-24625-1-git-send-email-catherine.hecx@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
prev parent reply other threads:[~2019-12-06 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 8:50 [PATCH] target/i386: relax assert when old host kernels don't include msrs Catherine Ho
2019-12-04 11:22 ` Paolo Bonzini
[not found] ` <CAEn6zmFex9WJ9jr5-0br7YzQZ=jA5bQn314OM+U=Q6ZGPiCRAg@mail.gmail.com>
2019-12-04 13:53 ` Paolo Bonzini
2019-12-04 15:07 ` Catherine Ho
2019-12-04 15:34 ` Paolo Bonzini
2019-12-04 15:47 ` Eduardo Habkost
2019-12-04 16:23 ` Paolo Bonzini
2019-12-06 10:23 ` [PATCH] target/i386: skip kvm_msr_entry_add when kvm_vmx_basic is 0 Catherine Ho
2019-12-06 10:28 ` Catherine Ho
2019-12-06 11:30 ` Paolo Bonzini
2019-12-06 23:48 ` no-reply [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157567613553.744.12283750572800820793@37313f22b938 \
--to=no-reply@patchew.org \
--cc=catherine.hecx@gmail.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).