From: Robert Hoo <robert.hu@linux.intel.com>
To: kvm@vger.kernel.org, pbonzini@redhat.com,
sean.j.christopherson@intel.com, xiaoyao.li@intel.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org
Cc: robert.hu@intel.com, Robert Hoo <robert.hu@linux.intel.com>
Subject: [RFC PATCH 0/9] Split kvm_update_cpuid_runtime()
Date: Fri, 31 Jul 2020 10:42:18 +0800 [thread overview]
Message-ID: <1596163347-18574-1-git-send-email-robert.hu@linux.intel.com> (raw)
kvm_update_cpuid_runtime() is currently called by various functions for the
purpose of updating vCPU's cpuid entries, due to specific runtime changes, e.g.
CR4 bits changes, XCR0 bits changes, etc. Each of them actually just needs to
update 1 ~ 2 CPUID entries. But current kvm_update_cpuid_runtime() packages all.
Given finding a target CPUID entry need to go through all CPUID entries, calling
kvm_update_cpuid_runtime() is a waste for each cause.
This patch set splits kvm_update_cpuid_runtime() into pieces according to
different updating causes.
Then let various callers call their specific necessary kvm_xxx_update_cpuid().
This not only significantly saves each caller's time, but also eliminates
unnecessary couplings.
Robert Hoo (9):
KVM:x86: Abstract sub functions from kvm_update_cpuid_runtime() and
kvm_vcpu_after_set_cpuid()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_apic_base_update_cpuid() in kvm_lapic_set_base()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_xcr0_update_cpuid() in __kvm_set_xcr()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_{osxsave,pke}_update_cpuid() in kvm_set_cr4()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_mwait_update_cpuid() in kvm_set_msr_common()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_{osxsave,pke}_update_cpuid() in enter_smm()
KVM:x86: Substitute kvm_update_cpuid_runtime() with
kvm_{osxsave,pke}_update_cpuid() in __set_sregs()
KVM:x86: Substitute kvm_vcpu_after_set_cpuid() with abstracted
functions
KVM:x86: Remove kvm_update_cpuid_runtime()
arch/x86/kvm/cpuid.c | 118 ++++++++++++++++++++++++++++++++++-----------------
arch/x86/kvm/cpuid.h | 7 ++-
arch/x86/kvm/lapic.c | 2 +-
arch/x86/kvm/x86.c | 29 ++++++++-----
4 files changed, 103 insertions(+), 53 deletions(-)
--
1.8.3.1
next reply other threads:[~2020-07-31 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 2:42 Robert Hoo [this message]
2020-07-31 2:42 ` [RFC PATCH 1/9] KVM:x86: Abstract sub functions from kvm_update_cpuid_runtime() and kvm_vcpu_after_set_cpuid() Robert Hoo
2020-09-29 4:56 ` Sean Christopherson
2020-10-20 5:38 ` Robert Hoo
2020-10-20 16:44 ` Sean Christopherson
2020-09-29 4:58 ` Sean Christopherson
2020-07-31 2:42 ` [RFC PATCH 2/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_apic_base_update_cpuid() in kvm_lapic_set_base() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 3/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_xcr0_update_cpuid() in __kvm_set_xcr() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 4/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_{osxsave,pke}_update_cpuid() in kvm_set_cr4() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 5/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_mwait_update_cpuid() in kvm_set_msr_common() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 6/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_{osxsave,pke}_update_cpuid() in enter_smm() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 7/9] KVM:x86: Substitute kvm_update_cpuid_runtime() with kvm_{osxsave,pke}_update_cpuid() in __set_sregs() Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 8/9] KVM:x86: Substitute kvm_vcpu_after_set_cpuid() with abstracted functions Robert Hoo
2020-07-31 2:42 ` [RFC PATCH 9/9] KVM:x86: Remove kvm_update_cpuid_runtime() Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596163347-18574-1-git-send-email-robert.hu@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).