From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>, arc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation
Date: Fri, 20 Mar 2020 18:54:29 +0100 [thread overview]
Message-ID: <17304566-fd9c-420d-17fe-89ef822362f6@redhat.com> (raw)
In-Reply-To: <758621ef-0ca1-d040-0979-c6359a3532d2@de.ibm.com>
On 20/03/20 15:29, Christian Borntraeger wrote:
>
>
> On 28.02.20 10:34, Paolo Bonzini wrote:
>> On 28/02/20 09:49, Christian Borntraeger wrote:
>>> Sparse notices that declaration and implementation do not match:
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: warning: incorrect type in return expression (different address spaces)
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: expected struct kvm_vcpu [noderef] <asn:3> **
>>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:4435:17: got struct kvm_vcpu *[noderef] <asn:3> *
>>>
>>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> include/linux/kvm_host.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
>>> index 7944ad6ac10b..bcb9b2ac0791 100644
>>> --- a/include/linux/kvm_host.h
>>> +++ b/include/linux/kvm_host.h
>>> @@ -1344,7 +1344,7 @@ static inline void kvm_vcpu_set_dy_eligible(struct kvm_vcpu *vcpu, bool val)
>>> #endif /* CONFIG_HAVE_KVM_CPU_RELAX_INTERCEPT */
>>>
>>> struct kvm_vcpu *kvm_get_running_vcpu(void);
>>> -struct kvm_vcpu __percpu **kvm_get_running_vcpus(void);
>>> +struct kvm_vcpu * __percpu *kvm_get_running_vcpus(void);
>>>
>>> #ifdef CONFIG_HAVE_KVM_IRQ_BYPASS
>>> bool kvm_arch_has_irq_bypass(void);
>>>
>>
>> Queued, thanks.
>
> Ping. I cant find this in kvm/next.
>
It's in 5.6-rc4.
Paolo
prev parent reply other threads:[~2020-03-20 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:49 [PATCH] KVM: let declaration of kvm_get_running_vcpus match implementation Christian Borntraeger
2020-02-28 9:34 ` Paolo Bonzini
2020-03-20 14:29 ` Christian Borntraeger
2020-03-20 17:54 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17304566-fd9c-420d-17fe-89ef822362f6@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).