From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1CEC47409 for ; Tue, 21 Jan 2020 14:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF60A2070C for ; Tue, 21 Jan 2020 14:26:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SkNEywdQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729182AbgAUO0g (ORCPT ); Tue, 21 Jan 2020 09:26:36 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43073 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727255AbgAUO0f (ORCPT ); Tue, 21 Jan 2020 09:26:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579616793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wB7oBUxPFMMo41Dhy/A6/q8IlRImdTJH/qsnmSwn8s8=; b=SkNEywdQxA2MNtBg974Sn0ZydviqoFf7LucDrjpzy39Tsk8ub9HgZig3tiUC1+XV8YjbVC dTZMVC1+cXJQ0Y9JvlxcvsQVNTw2JT79hjDojprlb9ehkrPWMN4i5j+ONb6/mm5FEXWbh0 xgCF491KvV5JkAxjJhjWm2briBhiIR8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-P7ihbnXFMq25UN9HpFPNhA-1; Tue, 21 Jan 2020 09:26:31 -0500 X-MC-Unique: P7ihbnXFMq25UN9HpFPNhA-1 Received: by mail-wr1-f69.google.com with SMTP id r2so1376061wrp.7 for ; Tue, 21 Jan 2020 06:26:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wB7oBUxPFMMo41Dhy/A6/q8IlRImdTJH/qsnmSwn8s8=; b=cle3657uAv6uZBozen3bFh25/zA4GUcXNuP1rqN+PY1jwE1IYh0GmtGy4ghq2UrBiy 23Uw8fo4fh9CUsXwxfdWEFDwWHbhGjll0Te2Ic018Q1crY8QqosajHDDAw0bpPcfo0Zp iKJbU4mSqySwaMpVOJwM0xYnast0i2UmJl80z//SIVlqw80C8r0NtqbgSaS4utbYZ4SY 5T9iPWk2GeyCf8uzMqf7+ZSKfL0YC/iwXFEkStyIO/gwbmJJzAspC3vJLfBTdkkIVl6z nPLL23Iu23BsZOkrjPdRAytVGWTeezkcK+LDTIp1TOvAAJ0MIQs/Au92pAHqoIV4HxvQ uoDQ== X-Gm-Message-State: APjAAAXMinNxwirTBuWZ6NQ8PfD0RkXJ3owKxQDVHCR4lEVBvT+eRdNx DQSxjt617uL4NpePBtleCPnvNIfFMV7K3hARFvEEAvnetQ3teEvdC95nfS0hBwuSrOMtnXeTenF RhHvs5FLGL3Vz X-Received: by 2002:a5d:6089:: with SMTP id w9mr5614954wrt.228.1579616790218; Tue, 21 Jan 2020 06:26:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxWjz4Oe+H/gSHDnoSQ5o2pah30WIinDPbt454AQ/QK4v/OQZOFatnXxkc9zEh4soAyNb9f2w== X-Received: by 2002:a5d:6089:: with SMTP id w9mr5614921wrt.228.1579616789896; Tue, 21 Jan 2020 06:26:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:b509:fc01:ee8a:ca8a? ([2001:b07:6468:f312:b509:fc01:ee8a:ca8a]) by smtp.gmail.com with ESMTPSA id q68sm4727432wme.14.2020.01.21.06.26.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2020 06:26:29 -0800 (PST) Subject: Re: [PATCH 05/14] x86/mm: Introduce lookup_address_in_mm() To: Thomas Gleixner , Sean Christopherson Cc: Paul Mackerras , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, syzbot+c9d1fb51ac9d0d10c39d@syzkaller.appspotmail.com, Andrea Arcangeli , Dan Williams , Barret Rhoden , David Hildenbrand , Jason Zeng , Dave Jiang , Liran Alon , linux-nvdimm References: <20200108202448.9669-1-sean.j.christopherson@intel.com> <20200108202448.9669-6-sean.j.christopherson@intel.com> <871rs8batm.fsf@nanos.tec.linutronix.de> From: Paolo Bonzini Message-ID: <175cef39-1e0e-d1b7-69bc-95a3a2a651a7@redhat.com> Date: Tue, 21 Jan 2020 15:26:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <871rs8batm.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 09/01/20 22:04, Thomas Gleixner wrote: > Sean Christopherson writes: > >> diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h >> index b5e49e6bac63..400ac8da75e8 100644 >> --- a/arch/x86/include/asm/pgtable_types.h >> +++ b/arch/x86/include/asm/pgtable_types.h >> @@ -561,6 +561,10 @@ static inline void update_page_count(int level, unsigned long pages) { } >> extern pte_t *lookup_address(unsigned long address, unsigned int *level); >> extern pte_t *lookup_address_in_pgd(pgd_t *pgd, unsigned long address, >> unsigned int *level); >> + >> +struct mm_struct; >> +pte_t *lookup_address_in_mm(struct mm_struct *mm, unsigned long address, >> + unsigned int *level); > > Please keep the file consistent and use extern even if not required. > > Other than that: > > Reviewed-by: Thomas Gleixner > Adjusted, thanks for the review. Paolo