From: Pankaj Gupta <pagupta@redhat.com>
To: Barret Rhoden <brho@google.com>
Cc: "Dan Williams" <dan.j.williams@intel.com>,
"David Hildenbrand" <david@redhat.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Ross Zwisler" <zwisler@kernel.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
"yu c zhang" <yu.c.zhang@intel.com>,
"yi z zhang" <yi.z.zhang@intel.com>
Subject: Re: [PATCH 2/2] kvm: Use huge pages for DAX-backed files
Date: Wed, 14 Nov 2018 04:09:47 -0500 (EST) [thread overview]
Message-ID: <1826878055.33695230.1542186587142.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20181113105628.37449f52@gnomeregan.cam.corp.google.com>
> > As this patch is dependent on PageReserved patch(which is in progress),
> > just
> > wondering if we are able to test the code path for hugepage with DAX.
>
> For testing, I used the following patch. It's not 100%, since it
> intercepts at kvm_is_reserved_pfn(), and not PageReserved() directly.
> The only difference is with kvm_set_pfn_dirty() I think.
>
Yes, this should be ok.
Thanks,
Pankaj
> I also have a nasty module that would dump the EPT's and the host page
> table's mappings so I could confirm that the huge pages are being mapped
> correctly.
>
> -----------------------
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 2679e476b6c3..1b394a0752a0 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -148,6 +148,10 @@ __weak int kvm_arch_mmu_notifier_invalidate_range(struct
> kvm *kvm,
>
> bool kvm_is_reserved_pfn(kvm_pfn_t pfn)
> {
> + // XXX hack
> + if (is_zone_device_page(pfn_to_page(pfn)))
> + return false;
> +
> if (pfn_valid(pfn))
> return PageReserved(pfn_to_page(pfn));
>
> -----------------------
>
> Thanks,
>
> Barret
>
>
next prev parent reply other threads:[~2018-11-14 9:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 20:39 [PATCH 0/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-09 20:39 ` [PATCH 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
[not found] ` <20181109203921.178363-2-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-13 9:28 ` David Hildenbrand
2018-11-09 20:39 ` [PATCH 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-12 19:31 ` Paolo Bonzini
[not found] ` <861c4adb-e2f0-2caf-8f6e-9f09ecb0b624-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 16:21 ` Barret Rhoden
2018-11-13 18:22 ` Paolo Bonzini
[not found] ` <20181109203921.178363-3-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-13 9:36 ` David Hildenbrand
[not found] ` <043a592d-6592-3053-15a0-68cc54a26deb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 10:02 ` Pankaj Gupta
2018-11-13 12:41 ` Paolo Bonzini
[not found] ` <286665658.33247363.1542103353780.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-11-13 15:56 ` Barret Rhoden
2018-11-14 9:09 ` Pankaj Gupta [this message]
2018-11-13 15:50 ` Barret Rhoden
[not found] ` <20181109203921.178363-1-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-14 21:51 ` [PATCH v2 0/3] " Barret Rhoden
[not found] ` <20181114215155.259978-1-brho-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2018-11-14 21:51 ` [PATCH v2 1/3] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2018-11-26 16:50 ` Paolo Bonzini
2018-11-26 18:32 ` Dan Williams
2018-11-14 21:51 ` [PATCH v2 2/3] kvm: Use huge pages for DAX-backed files Barret Rhoden
2018-11-14 21:51 ` [PATCH v2 3/3] kvm: remove redundant PageReserved() check Barret Rhoden
2018-11-27 13:31 ` David Hildenbrand
2018-11-15 0:55 ` [PATCH v2 0/3] kvm: Use huge pages for DAX-backed files Dan Williams
2018-12-03 17:40 ` Barret Rhoden
[not found] ` <20181203124051.05c1d2ce-5rj//V2oKXqT+5UN0cW69VLMcqb5oVE02SarAXORi/o@public.gmane.org>
2018-12-03 18:32 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1826878055.33695230.1542186587142.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=bp@alien8.de \
--cc=brho@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vishal.l.verma@intel.com \
--cc=x86@kernel.org \
--cc=yi.z.zhang@intel.com \
--cc=yu.c.zhang@intel.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).