Re: kvm-autotest: weird memory error during stepmaker test

[Michael Goldish <mgoldish@redhat.com>]

----- "Eduardo Habkost" <ehabkost@raisama.net> wrote:

> Excerpts from Ryan Harper's message of Qua Abr 01 12:55:58 -0300
> 2009:
> > Wondering if anyone else using kvm-autotest stepmaker has ever seen
> this
> > error:
> > 
> > Traceback (most recent call last):
> >   File
> >
> "/home/rharper/work/git/build/kvm-autotest/client/tests/kvm_runtest_2/stepmaker.
> > py", line 146, in update
> >     self.set_image_from_file(self.screendump_filename)
> >   File
> >
> "/home/rharper/work/git/build/kvm-autotest/client/tests/kvm_runtest_2/stepeditor
> > .py", line 499, in set_image_from_file
> >     self.set_image(w, h, data)
> >   File
> >
> "/home/rharper/work/git/build/kvm-autotest/client/tests/kvm_runtest_2/stepeditor
> > .py", line 485, in set_image
> >     w, h, w*3))
> > MemoryError
> 
> I've seen this error twice today, while trying to create a step file
> to
> install a Windows 2008 R2 64-bit guest (the Win2008-64 step file
> available on the git repository doesn't work for me). This happened
> when
> the guest was being rebooted by the windows installer. The contents
> of
> the screen dump file are this:
> 
> $ cat
> /home/ehabkost/autotest/kvm-autotest/client/results/default/kvm_runtest_2.Win2008.64.install/debug/scrdump.ppm
> P6
> 0 0
> 255
> $ 
> 
> And the 0x0 pixmap really makes gdk panic:
> 
> >>> (w, h, data) = 
> ppm_utils.image_read_from_ppm_file('/home/ehabkost/autotest/kvm-autotest/client/results/default/kvm_runtest_2.Win2008.64.install/debug/scrdump.ppm')
> >>> w,h,data
> (0, 0, '')
> >>> gtk.gdk.pixbuf_new_from_data(data, gtk.gdk.COLORSPACE_RGB, False,
> 8,  w, h, w*3)
> Traceback (most recent call last):
>   File "<stdin>", line 1, in ?
> MemoryError
> >>> 

This is very useful information. I've seen qemu/kvm produce 0x0 screendumps before,
but it's never happened to me while working with stepmaker.

A reasonable solution would be to make sure a screendump is OK before feeding it
to gdk. I'll try to commit this ASAP so it doesn't bother people any more.

Thanks,
Michael