From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16A8C433DF for ; Fri, 29 May 2020 10:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C12E2074B for ; Fri, 29 May 2020 10:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HjhWJ6EY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgE2KYH (ORCPT ); Fri, 29 May 2020 06:24:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:32863 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725914AbgE2KYG (ORCPT ); Fri, 29 May 2020 06:24:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590747844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pxDBHAtntdYo3/I5jF5RO1+05QKmLkITNesr/lf56qc=; b=HjhWJ6EYnxZfdO7Hvq/ud+CFcwWkYpnwpIZpM6SoKnbVUl0BUUEgsvvf+vN5vV1rpRjc8a swy4R2r9wFoScuik5+hQOR0mQUTiMrrRa83AKtS35cz3NsYba488JpVNIqDHwFy6gTNb6K eX5KboC/VArUkV4Z/QwEKXaLTE5fCQ4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-bpU5PwZwODOnc4fky0zoyg-1; Fri, 29 May 2020 06:24:03 -0400 X-MC-Unique: bpU5PwZwODOnc4fky0zoyg-1 Received: by mail-wm1-f69.google.com with SMTP id o8so2437053wmd.0 for ; Fri, 29 May 2020 03:24:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pxDBHAtntdYo3/I5jF5RO1+05QKmLkITNesr/lf56qc=; b=sI48VCgUuF5qxfekZqlVifh2RvnN9lb4+j3fpr/3Pz7EZtQEhcW8p+V59qPYEdNkA7 cZGfEcMkLw3yuclQMhNl4CUNT4zTHQJqTiORt95ac4LiS4yTwIhiyYtK/j5zyPc7z25D 1Quzqaa7QLoXY9mu71nQnw5wvBCBce0nK8emcl4jUwPlKlAEONTMDxR80cLc11F0wVqF kw7XiKJfwNMyBAiuW/h20zuTRqwIoiPjdv51oWHO9Do1TenT/rpxu48l4XSInZBxavY8 aXfsj+4HUe8NjCa/szoU4sMEPJeQ18pHKy+11tYDGubQWRAVa2CQdcHmPG+hRpA1qK7z TXKw== X-Gm-Message-State: AOAM533u3hIPzYW8irp/maozODV+fy95zxg+dnJSPn1JSTgQF9IRWvub O5FZLm52jD+eHSWfBzXiXyiQp5L/GK6hx3hNgsMxzAlT4uNZf87noFGb682aRVvDUltdkSbYkOx dudggWMZTgfNJ X-Received: by 2002:a1c:df57:: with SMTP id w84mr8387057wmg.52.1590747842078; Fri, 29 May 2020 03:24:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTJlbT0P7UibD2L2+OQYbTMuMmZmH8apUHkw6a/gvcox+qHPjE6vge9qVAIxlOiHSEMqBYiQ== X-Received: by 2002:a1c:df57:: with SMTP id w84mr8387030wmg.52.1590747841776; Fri, 29 May 2020 03:24:01 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:b096:1b7:7695:e4f7? ([2001:b07:6468:f312:b096:1b7:7695:e4f7]) by smtp.gmail.com with ESMTPSA id e6sm3010301wrx.80.2020.05.29.03.24.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 03:24:00 -0700 (PDT) Subject: Re: [Qemu-devel PATCH] target/i386: define a new MSR based feature word - FEAT_PERF_CAPABILITIES To: Like Xu Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Henderson , Eduardo Habkost , Marcelo Tosatti , qemu-devel@nongnu.org References: <20200529074347.124619-1-like.xu@linux.intel.com> <20200529074347.124619-5-like.xu@linux.intel.com> From: Paolo Bonzini Message-ID: <1aa68600-e48d-fa83-b2e2-b070a486afd4@redhat.com> Date: Fri, 29 May 2020 12:23:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200529074347.124619-5-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 29/05/20 09:43, Like Xu wrote: > + if (!cpu->enable_pmu) { > + *ecx &= ~CPUID_EXT_PDCM; > + } > break; > case 2: > /* cache info: needed for Pentium Pro compatibility */ > @@ -6505,6 +6528,12 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > } > } > > + if (kvm_enabled() && cpu->enable_pmu && > + (kvm_arch_get_supported_cpuid(kvm_state, 1, 0, R_ECX) & > + CPUID_EXT_PDCM)) { > + env->features[FEAT_1_ECX] |= CPUID_EXT_PDCM; > + } > + I'm dropping this hunk two hunks because it's going to break live migration with e.g. "-cpu IvyBridge,pmu=on". We will have to add PDCM by default only to future CPU models, but "-cpu host,pmu=on" will pick it up automatically. Paolo