From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH] kvm-autotest: add object addressing in sample cfg Date: Fri, 3 Apr 2009 07:52:15 -0500 Message-ID: <20090403125215.GD20681@us.ibm.com> References: <320283963.3887341238745823106.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <586625821.3887371238745874165.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ryan Harper , kvm@vger.kernel.org, Uri Lublin To: Michael Goldish Return-path: Received: from e1.ny.us.ibm.com ([32.97.182.141]:48510 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761453AbZDCMwf (ORCPT ); Fri, 3 Apr 2009 08:52:35 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n33CnShg012582 for ; Fri, 3 Apr 2009 08:49:28 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n33CqHfj187028 for ; Fri, 3 Apr 2009 08:52:17 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n33CogEi008742 for ; Fri, 3 Apr 2009 08:50:42 -0400 Content-Disposition: inline In-Reply-To: <586625821.3887371238745874165.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Michael Goldish [2009-04-03 03:04]: > > ----- "Ryan Harper" wrote: > > > The wiki documents[1] object addressing quite well, but we should > > include it in the example config file as well. > > > > 1. > > http://www.linux-kvm.org/page/KVM-Autotest/Parameters#Addressing_objects_.28VMs.2C_images.2C_NICs_etc.29 > > > > > > -- > > Ryan Harper > > Software Engineer; Linux Technology Center > > IBM Corp., Austin, Tx > > ryanh@us.ibm.com > > > > > > diffstat output: > > kvm_tests.cfg.sample | 4 ++++ > > 1 files changed, 4 insertions(+) > > > > Signed-off-by: Ryan Harper > > --- > > diff --git a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample > > b/client/tests/kvm_runtest_2/kvm_tests.cfg.sample > > index 5619fa8..64f8e4b 100644 > > --- a/client/tests/kvm_runtest_2/kvm_tests.cfg.sample > > +++ b/client/tests/kvm_runtest_2/kvm_tests.cfg.sample > > @@ -19,6 +19,10 @@ image_size = 10G > > ssh_port = 22 > > display = vnc > > > > +# specify specific values for vm1 and nic1 > > +mem_vm1 = 256 > > +nic_model_nic1 = rtl8139 > > + > > # Port redirections > > redirs = ssh > > guest_port_ssh = 22 > > This may not be a good idea, because we'll end up using only rtl8139. > Further down in the file we define virtio and e1000 variants. The e1000 one, for example, > specifies 'nic_model = e1000'. So you'll get a dict that contains: > > nic_model_vm1 = rtl8139 > nic_model = e1000 > > and the second statement will have no effect on vm1, because object specific statements > take precedence over general ones, regardless of order (as mentioned in the wiki). > > Also, we'll end up always using mem = 256 (isn't that too little for some guests?). Right, I meant it as an example of an override and object assignment. I didn't mean to imply that it should be the new default. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com