From: David Miller <davem@davemloft.net>
To: borntraeger@de.ibm.com
Cc: alex.williamson@hp.com, rusty@rustcorp.com.au,
netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: virtio_net: MAC address releated breakage if there is no MAC area in config
Date: Sat, 04 Apr 2009 16:40:31 -0700 (PDT) [thread overview]
Message-ID: <20090404.164031.03580665.davem@davemloft.net> (raw)
In-Reply-To: <200904021923.48907.borntraeger@de.ibm.com>
From: Christian Borntraeger <borntraeger@de.ibm.com>
Date: Thu, 2 Apr 2009 19:23:48 +0200
> Am Thursday 02 April 2009 18:06:25 schrieb Alex Williamson:
> > virtio_net: Set the mac config only when VIRITO_NET_F_MAC
> >
> > VIRTIO_NET_F_MAC indicates the presence of the mac field in config
> > space, not the validity of the value it contains. Allow the mac to be
> > changed at runtime, but only push the change into config space with the
> > VIRTIO_NET_F_MAC feature present.
> >
> > Signed-off-by: Alex Williamson <alex.williamson@hp.com>
>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Applied, thanks!
next prev parent reply other threads:[~2009-04-04 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 11:33 virtio_net: MAC address releated breakage if there is no MAC area in config Christian Borntraeger
2009-04-02 16:06 ` Alex Williamson
2009-04-02 17:23 ` Christian Borntraeger
2009-04-04 23:40 ` David Miller [this message]
2009-04-05 13:19 ` Rusty Russell
2009-04-05 3:41 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090404.164031.03580665.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alex.williamson@hp.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).