kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Uri Lublin <uril@redhat.com>, Ryan Harper <ryanh@us.ibm.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid
Date: Sun, 5 Apr 2009 14:33:03 -0300	[thread overview]
Message-ID: <20090405173303.GR21507@blackpad> (raw)
In-Reply-To: <49D8A487.9060803@redhat.com>

On Sun, Apr 05, 2009 at 03:31:03PM +0300, Avi Kivity wrote:
> Eduardo Habkost wrote:
>>>>>> SPACE_RGB, False, 8,  w, h, w*3)
>>>>>>           
>>> Traceback (most recent call last):
>>>   File "<stdin>", line 1, in ?
>>> MemoryError
>>>     
>>
>>
<snip>
>>   
>
> Instead of returning an empty image here, we should throw an exception.   
> Qemu shouldn't write invalid image.

Throwing an exception is exactly what the current code does, and what I
want to prevent. stepeditor is a GUI application, there is no point in
aborting because the image is invalid during a small time window.

But fixing qemu is welcome, of course.

>
> I've just sent a patch to qemu-devel which may help with this.

-- 
Eduardo

  reply	other threads:[~2009-04-05 17:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 15:55 kvm-autotest: weird memory error during stepmaker test Ryan Harper
2009-04-03 20:37 ` Eduardo Habkost
2009-04-03 21:43   ` [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid Eduardo Habkost
2009-04-05 12:31     ` Avi Kivity
2009-04-05 17:33       ` Eduardo Habkost [this message]
2009-04-05 17:33       ` Uri Lublin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090405173303.GR21507@blackpad \
    --to=ehabkost@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ryanh@us.ibm.com \
    --cc=uril@redhat.com \
    --subject='Re: [PATCH] kvm-autotest: stepeditor: clear image if width, height, or data are invalid' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox