From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH 2/8] move qemu-kvm.c to kvm-all.c
Date: Wed, 8 Jul 2009 10:52:56 -0300
Message-ID: <20090708135256.GB3528@poweredge.glommer>
References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> <4A549DDB.6030200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45616 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755322AbZGHNqW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 8 Jul 2009 09:46:22 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n68DkMu3007601
	for <kvm@vger.kernel.org>; Wed, 8 Jul 2009 09:46:22 -0400
Content-Disposition: inline
In-Reply-To: <4A549DDB.6030200@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Jul 08, 2009 at 04:23:39PM +0300, Avi Kivity wrote:
> On 07/08/2009 04:08 PM, Glauber Costa wrote:
>> Big plan to start sharing code with upstream.
>>
>>    
>
> This patch is very brittle - if qemu-kvm.c changes, it won't apply.  I  
> suggest to simply add #include "qemu-kvm.c" and remove it from the  
> makefile.  After I apply it, I'll perform the #include and remove  
> qemu-kvm.c.
ok.

I'll do the same with kvm.c