kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	linuxram@us.ibm.com, qemu-devel@nongnu.org,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] rev3: support colon in filenames
Date: Wed, 15 Jul 2009 23:00:12 +0100	[thread overview]
Message-ID: <20090715220012.GP3056@shareable.org> (raw)
In-Reply-To: <4A5E4D33.9070901@web.de>

Jan Kiszka wrote:
> Jamie Lokier wrote:
> > Jan Kiszka wrote:
> >>> Now, I see one significant hurdle with that: it's quite inconvenient
> >>> for Windows users, typing paths like c:\path\to\dir\file, if those
> >>> backslashes are stipped.
> >> We could exclude Windows from this (I think to remember that filenames
> >> are more restricted there anyway) or define a different, Windows-only
> >> escape character.
> > 
> > I think both of those are bad ideas, because the same management
> > scripts can run on Windows, and for consistency it's not just file
> > names.  Even Windows has block devices and network devices :-)
> 
> I'm not sure if there is actually so much portability/reusability
> between Windows and the rest of the universe, but I'm surely not an
> expert in this.

In my experience, shell scripts and Perl scripts tend to work either
with no changes, or very small changes.

> > Fortunately "where <char> is not ASCII alphanumeric" solves the
> > practical cases where the user types an ordinary pathname.
> > 
> > Or the user can type forward slashes just like they do in unix.
> 
> We would still have to deal with the fact that so far '\' had no special
> meaning on Windows - except that is was the well-known path separator.
> So redefining its meaning would break a bit...

The point is that paths tend to have alphanumeric characters at the
start of each component, so it doesn't matter in most cases that it's
redefined.  People won't notice because c:\path\to\file will continue
to work, whether it's by itself or part of a multi-option option.

Exceptions are \\host\path and \\.\device, where the error will be so
obvious they'll learn quickly.  We could find a more complex scheme
where \\ is unaffected, but complex is not good and will be wrongly
implemented by other programs.

Whereas \<char> is very common, well known and easy to get right, even
when people guess how it's done, like they do when working out how to
quote paths for rsync and ssh.

Oh, I'm suddenly thinking that "." should be included in "alphanumeric" :-)

-- Jamie

  reply	other threads:[~2009-07-15 22:00 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 16:58 [PATCH] support colon in filenames Ram Pai
2009-06-24 17:08 ` Balbir Singh
2009-06-24 17:30   ` Ram Pai
2009-06-24 18:31     ` Balbir Singh
2009-06-24 17:26 ` Amit Shah
2009-06-24 17:27   ` Amit Shah
2009-06-24 17:57 ` Ram Pai
2009-06-25  9:14   ` Kevin Wolf
2009-06-25 17:52     ` Ram Pai
2009-06-26  6:53       ` Kevin Wolf
2009-06-26  6:38     ` rev1 " Ram Pai
2009-06-26  7:45       ` Kevin Wolf
2009-06-27  0:41         ` rev2 " Ram Pai
2009-07-02  5:08           ` [PATCH] rev3: " Ram Pai
2009-07-02  8:52             ` [Qemu-devel] " Kevin Wolf
2009-07-02 12:52               ` Anthony Liguori
2009-07-02 13:18                 ` Kevin Wolf
2009-07-08  8:30                   ` [PATCH] rev4: " Ram Pai
2009-07-08 15:05                     ` Jan Kiszka
2009-07-10 13:31                     ` Anthony Liguori
2009-07-15  7:51                     ` [PATCH] rev5: " Ram Pai
2009-07-15  9:30                       ` Jan Kiszka
2009-07-15 17:03                         ` Ram Pai
2009-07-15 18:20                           ` [Qemu-devel] " Jamie Lokier
2009-07-15 18:44                             ` Ram Pai
2009-07-15 21:04                               ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Jamie Lokier
2009-07-15 21:14                                 ` qcow2 relative paths Jan Kiszka
2009-07-16  2:28                                 ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Ram Pai
2009-07-16  7:38                                   ` qcow2 relative paths Kevin Wolf
2009-07-16  7:51                                     ` Ram Pai
2009-07-16  7:39                                 ` [PATCH] rev6: support colon in filenames Ram Pai
2009-07-17 23:17                                   ` [PATCH] rev7: " Ram Pai
2009-07-21 12:42                                     ` Kevin Wolf
2009-08-06  6:27                                       ` Ram Pai
2009-08-06  6:47                                         ` [PATCH] rev8: " Ram Pai
2009-07-15 15:04                       ` [Qemu-devel] [PATCH] rev5: " Blue Swirl
2009-07-15 15:14                         ` Anthony Liguori
2009-07-15 15:29                           ` Blue Swirl
2009-07-15 15:40                             ` Anthony Liguori
2009-07-15 16:42                               ` Kevin Wolf
2009-07-15 17:47                               ` Michael S. Tsirkin
2009-07-16 10:57                               ` Amit Shah
2009-07-16 13:43                               ` Markus Armbruster
2009-07-16 14:10                                 ` Anthony Liguori
2009-07-16 15:13                                   ` Gerd Hoffmann
2009-07-16 15:12                                 ` Gerd Hoffmann
2009-07-15 15:34                           ` Kevin Wolf
2009-07-15 15:41                             ` Anthony Liguori
2009-07-15 15:52                           ` Paul Brook
2009-07-15 16:03                           ` Gerd Hoffmann
2009-07-15 16:08                             ` Paul Brook
2009-07-16  7:39                         ` Ram Pai
2009-07-16  7:43                           ` Kevin Wolf
2009-07-15 18:14                   ` [Qemu-devel] [PATCH] rev3: " Jamie Lokier
2009-07-15 20:54                     ` Jan Kiszka
2009-07-15 21:36                       ` Jamie Lokier
2009-07-15 21:42                         ` Jan Kiszka
2009-07-15 22:00                           ` Jamie Lokier [this message]
2009-07-15 22:16                           ` Anthony Liguori
2009-07-15 22:39                             ` Jamie Lokier
2009-07-15 22:41                               ` Anthony Liguori
2009-07-15 22:51                                 ` Jamie Lokier
2009-07-16  0:03                                   ` Anthony Liguori
2009-07-16  7:20                                     ` Jan Kiszka
2009-07-16  7:16                             ` Jan Kiszka
2009-07-16  8:01                     ` Kevin Wolf
2009-07-16 23:53                     ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715220012.GP3056@shareable.org \
    --to=jamie@shareable.org \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linuxram@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).