From: Rusty Russell <rusty@rustcorp.com.au>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
borntraeger@de.ibm.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: set QUEUE_ORDERED_DRAIN by default
Date: Thu, 27 Aug 2009 20:13:50 +0930 [thread overview]
Message-ID: <200908272013.50839.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4A952A5D.5040606@redhat.com>
On Wed, 26 Aug 2009 09:58:13 pm Avi Kivity wrote:
> On 08/26/2009 03:06 PM, Rusty Russell wrote:
> > On Tue, 25 Aug 2009 11:46:08 pm Christoph Hellwig wrote:
> >
> >> On Tue, Aug 25, 2009 at 11:41:37PM +0930, Rusty Russell wrote:
> >>
> >>> On Fri, 21 Aug 2009 06:26:16 am Christoph Hellwig wrote:
> >>>
> >>>> Currently virtio-blk doesn't set any QUEUE_ORDERED_ flag by default, which
> >>>> means it does not allow filesystems to use barriers. But the typical use
> >>>> case for virtio-blk is to use a backed that uses synchronous I/O
> >>>>
> >>> Really? Does qemu open with O_SYNC?
> >>>
> >>> I'm definitely no block expert, but this seems strange...
> >>> Rusty.
> >>>
> >> Qemu can open it various ways, but the only one that is fully safe
> >> is O_SYNC (cache=writethrough).
> >>
> > (Rusty goes away and reads the qemu man page).
> >
> > By default, if no explicit caching is specified for a qcow2 disk image,
> > cache=writeback will be used.
> >
>
> It's now switched to writethrough. In any case, cache=writeback means
> "lie to the guest, we don't care about integrity".
Well, that was the intent of the virtio barrier feature; *don't* lie to the
guest, make it aware of the limitations.
Of course, having read Christoph's excellent summary of the situation, it's
clear I failed.
> > Are you claiming qcow2 is unusual? I can believe snapshot is less common,
> > though I use it all the time.
> >
> > You'd normally have to add a feature for something like this. I don't
> > think this is different.
>
> Why do we need to add a feature for this?
Because cache=writeback should *not* lie to the guest?
Rusty.
next prev parent reply other threads:[~2009-08-27 10:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 20:56 [PATCH] virtio-blk: set QUEUE_ORDERED_DRAIN by default Christoph Hellwig
2009-08-21 7:30 ` Christian Borntraeger
2009-08-25 14:11 ` Rusty Russell
2009-08-25 14:16 ` Christoph Hellwig
2009-08-26 12:06 ` Rusty Russell
2009-08-26 12:28 ` Avi Kivity
2009-08-27 10:43 ` Rusty Russell [this message]
2009-08-27 11:04 ` Avi Kivity
2009-08-28 1:15 ` Rusty Russell
2009-08-28 6:33 ` Avi Kivity
2009-08-27 17:06 ` Christoph Hellwig
2009-09-17 17:31 ` Christoph Hellwig
2009-09-22 6:27 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908272013.50839.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).