From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCH kvm-unit-test 5/6] Add a simple kvmclock driver
Date: Fri, 27 Aug 2010 08:31:57 -0300
Message-ID: <20100827113157.GL2985@mothafucka.localdomain>
References: <20100827054733.7409.63882.stgit@FreeLancer>
 <20100827054945.7409.61366.stgit@FreeLancer>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: mtosatti@redhat.com, avi@redhat.com, kvm@vger.kernel.org
To: Jason Wang <jasowang@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34803 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753630Ab0H0LcA (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 27 Aug 2010 07:32:00 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7RBVx1k013004
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Fri, 27 Aug 2010 07:32:00 -0400
Content-Disposition: inline
In-Reply-To: <20100827054945.7409.61366.stgit@FreeLancer>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Aug 27, 2010 at 01:49:45PM +0800, Jason Wang wrote:
> +#define unlikely(x)	__builtin_expect(!!(x), 0)
> +
> +struct pvclock_vcpu_time_info hv_clock[MAX_CPU];
this structure have to be 4-byte aligned. Let the compiler
help you guaranteeing it here.

> +#define MAX_CPU 4
> +
Any particular reason for the number 4? I'd like
to see these tests running in really big boxes,
where things get really interesting.