From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Andreas Hartmann <andihartmann@01019freenet.de>,
<kvm@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: vfio: missing patch in linux 3.6
Date: Fri, 5 Oct 2012 15:08:57 +0200 [thread overview]
Message-ID: <20121005130857.GX4009@amd.com> (raw)
In-Reply-To: <1349368080.2759.52.camel@ul30vt.home>
On Thu, Oct 04, 2012 at 10:28:00AM -0600, Alex Williamson wrote:
> There are a couple questions in the link above. Since the devices don't
> expose a PCIe capability, we probably need to add a check to look at the
> upstream device and verify we're not on a legacy bus where ACS can't be
> enforced.
You can certainly do that, but for existing hardware (with an AMD IOMMU)
this check would never be true. These devices are always on a seperate
south-bridge chip which is connected to the north-bridge via PCIe. So
the topology where you find these devices is always the same in an AMD
IOMMU system.
> Then there's the general question of whether the confirmation
> of no peer-to-peer applies to every case where we might see this device
> (some of them seem to have history that pre-dates this specific package
> implementation) or do we need to try to identify specific package
> properties in addition to just a device ID?
The device ids are kept the same to maintain compatability with older
software. Besides that, my statement about the peer-2-peer safety is
true for all south-bridges that you can find in an AMD IOMMU capable
system.
Regards,
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-10-05 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 15:13 vfio: missing patch in linux 3.6 Andreas Hartmann
2012-10-04 15:26 ` Alex Williamson
2012-10-04 15:57 ` Andreas Hartmann
2012-10-04 16:14 ` Roedel, Joerg
2012-10-04 16:28 ` Alex Williamson
2012-10-05 13:08 ` Roedel, Joerg [this message]
2012-10-14 15:07 ` Andreas Hartmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005130857.GX4009@amd.com \
--to=joerg.roedel@amd.com \
--cc=alex.williamson@redhat.com \
--cc=andihartmann@01019freenet.de \
--cc=bhelgaas@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).