Re: [PATCH v3 17/18] x86/kvm/tsc: Drop extra barrier and use rdtsc_ordered in kvmclock

From: Borislav Petkov <bp@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>,
	x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
	John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
	Huang Rui <ray.huang@amd.com>,
	Denys Vlasenko <dvlasenk@redhat.com>,
	kvm@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Radim Krcmar <rkrcmar@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v3 17/18] x86/kvm/tsc: Drop extra barrier and use rdtsc_ordered in kvmclock
Date: Sat, 20 Jun 2015 23:50:46 +0200	[thread overview]
Message-ID: <20150620215046.GB30725@pd.tnic> (raw)
In-Reply-To: <558125FC.7010007@redhat.com>

On Wed, Jun 17, 2015 at 09:47:08AM +0200, Paolo Bonzini wrote:
> On 17/06/2015 02:36, Andy Lutomirski wrote:
> > __pvclock_read_cycles had an unnecessary barrier.  Get rid of that
> > barrier and clean up the code by just using rdtsc_ordered().
> > 
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Krcmar <rkrcmar@redhat.com>
> > Cc: Marcelo Tosatti <mtosatti@redhat.com>
> > Cc: kvm@vger.kernel.org
> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> > ---
> > 
> > I'm hoping to get an ack for this to go in through -tip.  (Arguably
> > I'm the maintainer of this code given how it's used, but I should
> > still ask for an ack.)
> > 
> > arch/x86/include/asm/pvclock.h | 21 ++++++++++++---------
> >  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> Can you send a URL to the rest of the series?  I've never even seen v1
> or v2 so I have no idea of what this is about.
> 
> > diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h
> > index 6084bce345fc..cf2329ca4812 100644
> > --- a/arch/x86/include/asm/pvclock.h
> > +++ b/arch/x86/include/asm/pvclock.h
> > @@ -62,7 +62,18 @@ static inline u64 pvclock_scale_delta(u64 delta, u32 mul_frac, int shift)
> >  static __always_inline
> >  u64 pvclock_get_nsec_offset(const struct pvclock_vcpu_time_info *src)
> >  {
> > -	u64 delta = rdtsc() - src->tsc_timestamp;
> > +	/*
> > +	 * Note: emulated platforms which do not advertise SSE2 support
> > +	 * break rdtsc_ordered, resulting in kvmclock not using the
> > +	 * necessary RDTSC barriers.  Without barriers, it is possible
> > +	 * that RDTSC instruction is executed before prior loads,
> > +	 * resulting in violation of monotonicity.
> > +	 *
> > +	 * On an SMP guest without SSE2, it's unclear how anything is
> > +	 * supposed to work correctly, though -- memory fences
> > +	 * (e.g. smp_mb) are important for more than just timing.
> > +	 */
> 
> On an SMP guest without SSE2, memory fences are obtained with e.g. "lock
> addb $0, (%esp)".

Yeah, I killed that comment when applying.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe kvm" in