linux-next: Fixes tag needs some work in the kvm tree

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

Hi all,

In commit

  aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable")

Fixes tag

  Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return

has these problem(s):

  - Subject has leading but no trailing quotes
    Please do not split Fixes tags over more than one line

In commit

  4d3f8e4ff75e ("kvm: vmx: Fix typos in vmentry/vmexit control setting")

Fixes tag

  Fixes: 'commit f99e3daf94ff ("KVM: x86: Add Intel PT virtualization work mode")'

has these problem(s):

  - No SHA1 recognised
    The leading word 'commit' is unexpected and the surrounding single
    quotes likewise.
    Please just use
	git log -1 --format='Fixes: %h ("%s")' <SHA>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm tree

[Yu Zhang]

Thanks for the notification, Stephen.
@Paolo, should I resubmit the patch to correct?

On Sat, Feb 16, 2019 at 06:34:33PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable")
> 
> Fixes tag
> 
>   Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>     Please do not split Fixes tags over more than one line
> 
> In commit
> 
>   4d3f8e4ff75e ("kvm: vmx: Fix typos in vmentry/vmexit control setting")
> 
> Fixes tag
> 
>   Fixes: 'commit f99e3daf94ff ("KVM: x86: Add Intel PT virtualization work mode")'
> 
> has these problem(s):
> 
>   - No SHA1 recognised
>     The leading word 'commit' is unexpected and the surrounding single
>     quotes likewise.
>     Please just use
> 	git log -1 --format='Fixes: %h ("%s")' <SHA>
> 
> -- 
> Cheers,
> Stephen Rothwell

B.R.
Yu

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

Hi all,

In commit

  caadf876bb74 ("KVM: introduce CONFIG_KVM_COMMON")

Fixes tag

  Fixes: 8132d887a702 ("KVM: remove CONFIG_HAVE_KVM_EVENTFD", 2023-12-08)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

The date string adds nothing.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Hi all,

In commit

  594a1c271c15 ("KVM: selftests: Fix filename reporting in guest asserts")

Fixes tag

  Fixes: 4e18bccc2e5544f0be28fc1c4e6be47a469d6c60

has these problem(s):

  - missing subject

Please just use

  git log -1 --format='Fixes: %h ("%s")' <commit>

So

Fixes: 4e18bccc2e55 ("kvm: selftest: unify the guest port macros")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

In commit

  abaaf90e1cb9 ("KVM: LAPIC: Drop pending LAPIC timer injection when canceling the timer")

Fixes tag

  Fixes: 4427593258 (KVM: x86: thoroughly disarm LAPIC timer around TSC deadline switch)

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi all,

In commit

  32c8644b37cf ("kvm: selftests: conditionally build vm_xsave_req_perm()")

Fixes tag

  Fixes: 415a3c33e8 ("kvm: selftests: Add support for KVM_CAP_XSAVE2")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed in the future by setting core.abbrev to 12 (or more) or
    (for git v2.11 or later) just making sure it is not set (or set to
    "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

Hi all,

In commit

  81b4b56d4f81 ("KVM: VMX: avoid running vmx_handle_exit_irqoff in case of emulation")

Fixes tag

  Fixes: 95b5a48c4f2b ("KVM: VMX: Handle NMIs, #MCs and async #PFs in common irqs-disabled fn", 2019-06-18)

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The date part does not add anything, please don't add it.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi all,

In commit

  f7782bb8d818 ("KVM: nVMX: Unconditionally clear nested.pi_pending on nested VM-Enter")

Fixes tag

  Fixes: 47d3530f86c0 ("KVM: x86: Exit to userspace when kvm_check_nested_events fails")

has these problem(s):

  - Target SHA1 does not exist

I can't easily find the intended commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm tree

[Paolo Bonzini]

On 22/06/21 00:18, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    ade74e1433f3 ("KVM: x86/mmu: Grab nx_lpage_splits as an unsigned long before division")
> 
> Fixes tag
> 
>    Fixes: 7ee093d4f3f5 ("KVM: switch per-VM stats to u64")
> 
> has these problem(s):
> 
>    - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: e3cb6fa0e2bf ("KVM: switch per-VM stats to u64")
> 
> It is very hard to get the commit SHA right when the commit you are
> "fixing" is after the fix commit :-)

Yeah, that Fixes tag should have been removed since the patch can be 
kept separate (does not have to be squashed).

Paolo

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

In commit

  ade74e1433f3 ("KVM: x86/mmu: Grab nx_lpage_splits as an unsigned long before division")

Fixes tag

  Fixes: 7ee093d4f3f5 ("KVM: switch per-VM stats to u64")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: e3cb6fa0e2bf ("KVM: switch per-VM stats to u64")

It is very hard to get the commit SHA right when the commit you are
"fixing" is after the fix commit :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm tree

[Christian Borntraeger]

On 16.04.21 16:58, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 16/04/21 14:38, Christian Borntraeger wrote:
>>> On 16.04.21 14:27, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>     c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
>>>>
>>>> Fixes tag
>>>>
>>>>     Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
>>>>
>>>> has these problem(s):
>>>>
>>>>     - Subject does not match target commit subject
>>>>       Just use
>>>>      git log -1 --format='Fixes: %h ("%s")'
>>>
>>> Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
>>>    
>>
>> Maybe you just missed it when it was reported for kvms390?
>>
>> https://www.spinics.net/lists/linux-next/msg59652.html
> 
> It was a different commit SHA then and was reported because the Fixes
> SHA did not exist.  It was fixed the next day, so I guess either I
> missed reporting this different problem, or I thought at least it had
> been fixed to use the correct SHA.  I am not completely consistent,
> sometimes :-)

Yeah, seems that my fix was only half-way correct then but it managed to get past your review.

Re: linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

Hi all,

On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 16/04/21 14:38, Christian Borntraeger wrote:
> > On 16.04.21 14:27, Stephen Rothwell wrote:  
> >> Hi all,
> >>
> >> In commit
> >>
> >>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
> >>
> >> Fixes tag
> >>
> >>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
> >>
> >> has these problem(s):
> >>
> >>    - Subject does not match target commit subject
> >>      Just use
> >>     git log -1 --format='Fixes: %h ("%s")'  
> > 
> > Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
> >   
> 
> Maybe you just missed it when it was reported for kvms390?
> 
> https://www.spinics.net/lists/linux-next/msg59652.html

It was a different commit SHA then and was reported because the Fixes
SHA did not exist.  It was fixed the next day, so I guess either I
missed reporting this different problem, or I thought at least it had
been fixed to use the correct SHA.  I am not completely consistent,
sometimes :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the kvm tree

[Paolo Bonzini]

On 16/04/21 14:38, Christian Borntraeger wrote:
> On 16.04.21 14:27, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and 
>> MSO")
>>
>> Fixes tag
>>
>>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in 
>> VSIE")
>>
>> has these problem(s):
>>
>>    - Subject does not match target commit subject
>>      Just use
>>     git log -1 --format='Fixes: %h ("%s")'
> 
> Hmm, this has been sitting in kvms390/next for some time now. Is this a 
> new check?
> 

Maybe you just missed it when it was reported for kvms390?

https://www.spinics.net/lists/linux-next/msg59652.html

The SHA1 is stable now so it's too late.  It's not a big deal I guess.

Paolo

Re: linux-next: Fixes tag needs some work in the kvm tree

[Christian Borntraeger]

On 16.04.21 14:27, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and MSO")
> 
> Fixes tag
> 
>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in VSIE")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hmm, this has been sitting in kvms390/next for some time now. Is this a new check?

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi all,

In commit

  c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and MSO")

Fixes tag

  Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in VSIE")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

In commit

  f1b3b06a058b ("KVM: x86/mmu: Clear dirtied pages mask bit before early break")

Fixes tag

  Fixes: a6a0b05da9f3 ("kvm: x86/mmu: Support dirty logging for the TDP

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  abbed4fa94f6 ("KVM: x86: Fix warning due to implicit truncation on 32-bit KVM")

Fixes tag

  Fixes: a3e967c0b87d3 ("KVM: Terminate memslot walks via used_slots"

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 0577d1abe704 ("KVM: Terminate memslot walks via used_slots")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Hi all,

In commit

  90bbff59a2fb ("KVM: x86/mmu: Enforce max_level on HugeTLB mappings")

Fixes tag

  Fixes: ad163aa8903d ("KVM: x86/mmu: Persist gfn_lpage_is_disallowed() to max_level")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2f57b7051fe8 ("KVM: x86/mmu: Persist gfn_lpage_is_disallowed() to max_level")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the kvm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

In commit

  433f4ba19041 ("KVM: x86: fix out-of-bounds write in KVM_GET_EMULATED_CPUID (CVE-2019-19332)")

Fixes tag

  Fixes: 84cffe499b94 ("kvm: Emulate MOVBE", 2013-10-29)

has these problem(s):

  - Unexpected trailing date
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]