From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Yan Subject: Re: [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling Date: Wed, 3 Apr 2019 11:58:17 +0800 Message-ID: <20190403014730.GA5339@leoy-ThinkPad-X240s> References: <20190326074131.4284-1-leo.yan@linaro.org> <20190402165025.GA1442@fuggles.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marc Zyngier , Robin Murphy , kvmarm@lists.cs.columbia.edu To: Will Deacon Return-path: Content-Disposition: inline In-Reply-To: <20190402165025.GA1442@fuggles.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org Hi Will, On Tue, Apr 02, 2019 at 05:50:25PM +0100, Will Deacon wrote: > Hi Leo, > > On Tue, Mar 26, 2019 at 03:41:28PM +0800, Leo Yan wrote: > > When enable vfio-pci mode for NIC driver on Juno board, the IRQ is > > failed to forward properly from host to guest, finally root caused this > > issue is related with kvmtool cannot re-enable INTx mode properly. > > > > So the basic working flow to reproduce this issue is as below: > > > > Host Guest > > ------------- -------------------- > > INTx mode > > MSI enable failed in NIC driver > > MSI disable in NIC driver > > Switch back to INTx mode --> kvmtool doesn't support > > > > So this patch is to support INTx mode re-enabling; patch 0001 is one > > minor fixing up for eventfd releasing; patch 0002 introduces a new > > function vfio_pci_init_intx() which is used to finish INTx one-time > > initialisation; patch 0003 is the core patch for support INTx mode > > re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx > > mode. > > > > This patch set has been tested on Juno-r2 board. > > > > == Changes for V3 == > > * Add new function vfio_pci_init_intx() for one-time initialisation. > > * Simplized INTx re-enabling (don't change irq_line anymore at the > > runtime). > > Just checking, but is this series intended to supersede this one: > > https://www.spinics.net/lists/kvm/msg183750.html > > ? Yes, this patch series is v3 and the link you pointed out is the old patch series v1. Sorry for confusion. Thanks, Leo Yan