From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D3FCC4360F for ; Fri, 5 Apr 2019 15:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08FBE21726 for ; Fri, 5 Apr 2019 15:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731220AbfDEPbc (ORCPT ); Fri, 5 Apr 2019 11:31:32 -0400 Received: from foss.arm.com ([217.140.101.70]:51776 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbfDEPbc (ORCPT ); Fri, 5 Apr 2019 11:31:32 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A02416A3; Fri, 5 Apr 2019 08:31:32 -0700 (PDT) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E7493F68F; Fri, 5 Apr 2019 08:31:30 -0700 (PDT) Date: Fri, 5 Apr 2019 16:31:27 +0100 From: Andre Przywara To: Julien Thierry Cc: , , , Subject: Re: [PATCH kvmtool 08/16] arm/pci: Do not use first PCI IO space bytes for devices Message-ID: <20190405163127.4b10a581@donnerap.cambridge.arm.com> In-Reply-To: <1551947777-13044-9-git-send-email-julien.thierry@arm.com> References: <1551947777-13044-1-git-send-email-julien.thierry@arm.com> <1551947777-13044-9-git-send-email-julien.thierry@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 7 Mar 2019 08:36:09 +0000 Julien Thierry wrote: Hi, > Linux has this convention that the lower 0x1000 bytes of the IO space > should not be used. (cf PCIBIOS_MIN_IO). > > Just allocate those bytes to prevent future allocation assigning it to > devices. > > Signed-off-by: Julien Thierry > --- > arm/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arm/pci.c b/arm/pci.c > index 83238ca..559e0cf 100644 > --- a/arm/pci.c > +++ b/arm/pci.c > @@ -37,6 +37,9 @@ void pci__arm_init(struct kvm *kvm) > > /* Make PCI port allocation start at a properly aligned address */ > pci_get_io_space_block(align_pad); > + > + /* Convention, don't allocate first 0x1000 bytes of PCI IO */ > + pci_get_io_space_block(0x1000); Is this the same problem with mixing up I/O and MMIO space as in the other patch? io_space means MMIO, right? Cheers, Andre. > } > > void pci__generate_fdt_nodes(void *fdt)