From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08749C282CE for ; Wed, 24 Apr 2019 23:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDF78214C6 for ; Wed, 24 Apr 2019 23:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="k1XbnQHf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388006AbfDXXnz (ORCPT ); Wed, 24 Apr 2019 19:43:55 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:49326 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388005AbfDXXny (ORCPT ); Wed, 24 Apr 2019 19:43:54 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3ONdsLo121437; Wed, 24 Apr 2019 23:43:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=Et7E0aQ/SZqHheCiGa/XlkpciQtQvsl3r/kV5Qt3XFE=; b=k1XbnQHfjrd2xZnKKUTf01EOKH5fgCWnu2P1JLZQ4yZr9yfdZHgCJcma9LttWDN6OUHc zMMZIaIfiNFmk803XZrTh1wzNnNfAV4ps0o2NScJH8O7C1D/Z5Dn5Hl3CF7lzPdNwglJ eELjZRK2w266tdRVI7UZ768Dl+AXhylTIUxTmDTXS8yAhZoh2Dwu+bYL4AERfDiI4owx NWdmTo5DdisggVH+iFElW5+Q0D0zV6HPEOSl1mzz+qwCBeh/u2ubFYkscS2VLvYLq9QP nLQcy+EVmcU4zi2UP+44XXiBKuP6YgVHU+ToODfJe9XAsjqQFePba0sqR2+gxhuqmbZx 9w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2ryrxd5f92-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 23:43:40 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x3ONgTMN131604; Wed, 24 Apr 2019 23:43:40 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2s0fv3u6xh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Apr 2019 23:43:40 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x3ONhcGF004924; Wed, 24 Apr 2019 23:43:39 GMT Received: from ban25x6uut29.us.oracle.com (/10.153.73.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Apr 2019 16:43:38 -0700 From: Krish Sadhukhan To: kvm@vger.kernel.org Cc: pbonzini@redhat.com, rkrcmar@redhat.com, jmattson@google.com Subject: [PATCH 8/8][KVM nVMX]: Test "load IA32_PERF_GLOBAL_CTRL" controls on vmentry of nested guests Date: Wed, 24 Apr 2019 19:17:24 -0400 Message-Id: <20190424231724.2014-9-krish.sadhukhan@oracle.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190424231724.2014-1-krish.sadhukhan@oracle.com> References: <20190424231724.2014-1-krish.sadhukhan@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9237 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904240162 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9237 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904240162 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Archived-At: List-Archive: List-Post: ...to verify KVM performs the appropriate consistency checks for loading IA32_PERF_GLOBAL_CTRL as part of running a nested guest. According to section "Checks on Host Control Registers and MSRs" in Intel SDM vol 3C, the following checks are performed on vmentry of nested guests: If the "load IA32_PERF_GLOBAL_CTRL" VM-exit control is 1, bits reserved in the IA32_PERF_GLOBAL_CTRL MSR must be 0 in the field for that register. Signed-off-by: Krish Sadhukhan Reviewed-by: Karl Heubaum --- x86/vmx_tests.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c index 66a87f6..85fa8d5 100644 --- a/x86/vmx_tests.c +++ b/x86/vmx_tests.c @@ -4995,6 +4995,63 @@ static void test_sysenter_field(u32 field, const char *name) vmcs_write(field, addr_saved); } +#define PERF_GLOBAL_CTRL_VALID_BITS 0x0000000700000003 + +static void test_perf_global_ctl(u32 field, const char * field_name, + u32 ctrl_field, u64 ctrl_bit) +{ + u32 ctrl_saved = vmcs_read(ctrl_field); + u64 perf_global_saved = vmcs_read(field); + u64 i, val; + + vmcs_write(ctrl_field, ctrl_saved & ~ctrl_bit); + for (i = 0; i < 64; i++) { + val = 1ull << i; + vmcs_write(field, val); + report_prefix_pushf("\"load IA32_PERF_GLOBAL_CTRL\" " + "VM-exit control is off, HOST_PERF_GLOBAL_CTRL %lx", val); + test_vmx_vmlaunch(0, false); + report_prefix_pop(); + } + + vmcs_write(ctrl_field, ctrl_saved | ctrl_bit); + for (i = 0; i < 64; i++) { + val = 1ull << i; + vmcs_write(field, val); + report_prefix_pushf("\"load IA32_PERF_GLOBAL_CTRL\" " + "VM-exit control is on, HOST_PERF_GLOBAL_CTRL %lx", val); + if (PERF_GLOBAL_CTRL_VALID_BITS & (1ull << i)) { + test_vmx_vmlaunch(0, false); + } else { + test_vmx_vmlaunch(VMXERR_ENTRY_INVALID_HOST_STATE_FIELD, + false); + } + report_prefix_pop(); + } + + vmcs_write(ctrl_field, ctrl_saved); + vmcs_write(field, perf_global_saved); +} + +/* + * If the "load IA32_PERF_GLOBAL_CTRL" VM-exit control is 1, bits reserved + * in the IA32_PERF_GLOBAL_CTRL MSR must be 0 in the field for that + * register. + * + * [Intel SDM] + */ +static void test_host_perf_global_ctl(void) +{ + if (!(ctrl_exit_rev.clr & EXI_LOAD_PERF)) { + printf("\"load IA32_PERF_GLOBAL_CTRL\" VM-exit control not " + "supported\n"); + return; + } + + test_perf_global_ctl(HOST_PERF_GLOBAL_CTRL, "HOST_PERF_GLOBAL_CTRL", + EXI_CONTROLS, EXI_LOAD_PERF); +} + /* * Check that the virtual CPU checks the VMX Host State Area as * documented in the Intel SDM. @@ -5010,6 +5067,8 @@ static void vmx_host_state_area_test(void) test_sysenter_field(HOST_SYSENTER_ESP, "HOST_SYSENTER_ESP"); test_sysenter_field(HOST_SYSENTER_EIP, "HOST_SYSENTER_EIP"); + + test_host_perf_global_ctl(); } static bool valid_vmcs_for_vmentry(void) -- 2.17.2