From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A0CC31E46 for ; Wed, 12 Jun 2019 13:47:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCD7B208CA for ; Wed, 12 Jun 2019 13:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436759AbfFLNrK (ORCPT ); Wed, 12 Jun 2019 09:47:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436660AbfFLNrJ (ORCPT ); Wed, 12 Jun 2019 09:47:09 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4188F307D965; Wed, 12 Jun 2019 13:47:08 +0000 (UTC) Received: from gondolin (ovpn-116-169.ams2.redhat.com [10.36.116.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id D24AA60922; Wed, 12 Jun 2019 13:46:58 +0000 (UTC) Date: Wed, 12 Jun 2019 15:46:55 +0200 From: Cornelia Huck To: Halil Pasic Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Sebastian Ott , Heiko Carstens , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Michael Mueller , Claudio Imbrenda , Farhan Ali , Eric Farman , "Jason J. Herne" Subject: Re: [PATCH v4 4/8] s390/airq: use DMA memory for adapter interrupts Message-ID: <20190612154655.1fcc2cd4.cohuck@redhat.com> In-Reply-To: <20190612153324.3dc6632c.pasic@linux.ibm.com> References: <20190606115127.55519-1-pasic@linux.ibm.com> <20190606115127.55519-5-pasic@linux.ibm.com> <20190611121721.61bf09b4.cohuck@redhat.com> <20190611162721.67ca8932.pasic@linux.ibm.com> <20190611181944.5bf2b953.cohuck@redhat.com> <20190612023231.7da4908c.pasic@linux.ibm.com> <20190612082127.3fd63091.cohuck@redhat.com> <20190612153324.3dc6632c.pasic@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Wed, 12 Jun 2019 13:47:09 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 12 Jun 2019 15:33:24 +0200 Halil Pasic wrote: > On Wed, 12 Jun 2019 08:21:27 +0200 > Cornelia Huck wrote: > > > On Wed, 12 Jun 2019 02:32:31 +0200 > > Halil Pasic wrote: > > > > > On Tue, 11 Jun 2019 18:19:44 +0200 > > > Cornelia Huck wrote: > > > > > > > On Tue, 11 Jun 2019 16:27:21 +0200 > > > > Halil Pasic wrote: > > > > > > > IMHO the cleanest thing to do at this stage is to check if the > > > > > airq_iv_cache is NULL and fail the allocation if it is (to preserve > > > > > previous behavior). > > > > > > > > That's probably the least invasive fix for now. Did you check whether > > > > any of the other dma pools this series introduces have a similar > > > > problem due to init not failing? > > > > > > > > > > Good question! > > > > > > I did a quick check. virtio_ccw_init() should be OK, because we don't > > > register the driver if allocation fails, so the thing is going to end > > > up dysfunctional as expected. > > > > > > If however cio_dma_pool_init() fails, then we end up with the same > > > problem with airqs, just on the !AIRQ_IV_CACHELINE code path. It can be > > > fixed analogously: make cio_dma_zalloc() fail all allocation if > > > cio_dma_pool_init() failed before. > > > > Ok, makes sense. > > v5 is out with the fixes. I have no ack/r-b from you for patch 4. Would > you like to give some, or should I proceed without? Please give this some more time, I will look at this later.