From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65559C46477 for ; Thu, 13 Jun 2019 16:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4824420679 for ; Thu, 13 Jun 2019 16:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733311AbfFMQDJ (ORCPT ); Thu, 13 Jun 2019 12:03:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731392AbfFMQDI (ORCPT ); Thu, 13 Jun 2019 12:03:08 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B446B882F2; Thu, 13 Jun 2019 16:03:08 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id C79E31001B22; Thu, 13 Jun 2019 16:03:07 +0000 (UTC) Date: Thu, 13 Jun 2019 18:03:05 +0200 From: Cornelia Huck To: Eric Farman Cc: Farhan Ali , Halil Pasic , linux-s390@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v2 7/9] vfio-ccw: Remove pfn_array_table Message-ID: <20190613180305.3aeeae1d.cohuck@redhat.com> In-Reply-To: <20190606202831.44135-8-farman@linux.ibm.com> References: <20190606202831.44135-1-farman@linux.ibm.com> <20190606202831.44135-8-farman@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 13 Jun 2019 16:03:08 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 6 Jun 2019 22:28:29 +0200 Eric Farman wrote: > Now that both CCW codepaths build this nested array: > > ccwchain->pfn_array_table[1]->pfn_array[#idaws/#pages] > > We can collapse this into simply: > > ccwchain->pfn_array[#idaws/#pages] > > Let's do that, so that we don't have to continually navigate two > nested arrays when the first array always has a count of one. > > Signed-off-by: Eric Farman > --- > drivers/s390/cio/vfio_ccw_cp.c | 118 +++++++++------------------------ > 1 file changed, 33 insertions(+), 85 deletions(-) That's how I like my diffstats :) Nice cleanup! Reviewed-by: Cornelia Huck