From: Cornelia Huck <firstname.lastname@example.org> To: Alex Williamson <email@example.com> Cc: Christophe de Dinechin <firstname.lastname@example.org>, Sylvain Bauza <email@example.com>, Pavel Hrdina <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Skultety <email@example.com>, Libvirt Devel <firstname.lastname@example.org>, Kirti Wankhede <email@example.com> Subject: Re: [libvirt] mdevctl: A shoestring mediated device management and persistence utility Date: Mon, 17 Jun 2019 18:03:26 +0200 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On Fri, 14 Jun 2019 10:04:18 -0600 Alex Williamson <firstname.lastname@example.org> wrote: > On Fri, 14 Jun 2019 17:06:15 +0200 > Christophe de Dinechin <email@example.com> wrote: > > > > On 14 Jun 2019, at 16:23, Alex Williamson <firstname.lastname@example.org> wrote: > > > > > > On Fri, 14 Jun 2019 11:54:42 +0200 > > > Christophe de Dinechin <email@example.com> wrote: > > > Where is the parent/type ownership implied? > > > > I did not imply it, but I read some concern about ownership > > on your part in "they need to guess that an mdev device > > with the same parent and type is *theirs*.” (emphasis mine) > > > > I personally see no change on the “need to guess” implied > > by the fact that you run uuidgen inside the script, so > > that’s why I tried to guess what you meant. > > As I noted in the reply to the pull request, putting `uuidgen` inline > was probably a bad example. FWIW, I just sent a pull req to get rid of that inline `uuidgen` in the example. > However, the difference is that the user > has imposed the race on themselves if they invoke mdevctl like this, > they've provided a uuid but they didn't record what it is. This is the > user's problem. Pushing uuid selection into mdevctl makes it mdevctl's > problem because the interface is fundamentally broken. > > > > The intended semantics are > > > "try to create this type of device under this parent”. > > > > Agreed. Which is why I don’t see why trying to create > > with some new UUID introduces any race (as long as > > the script prints out that UUID, which I admit my patch > > entirely failed to to) > > And that's the piece that makes it fundamentally broken. Beyond that, > it seems unnecessary. I don't see this as the primary invocation of > mdevctl and the functionality it adds is trivially accomplished in a > wrapper, so what's the value? > > > >>> How do you resolve two instances of this happening in parallel and both > > >>> coming to the same conclusion which is their device. If a user wants > > >>> this sort of headache they can call mdevctl with `uuidgen` but I don't > > >>> think we should encourage it further. > > >> > > >> I agree there is a race, but if anything, having a usage where you don’t > > >> pass the UUID on the command line is a step in the right direction. > > >> It leaves the door open for the create-mdev script to do smarter things, > > >> like deferring the allocation of the mdevs to an entity that has slightly > > >> more knowledge of the global system state than uuidgen. > > > > > > A user might (likely) require a specific uuid to match their VM > > > configuration. I can only think of very niche use cases where a user > > > doesn't care what uuid they get. > > > > They do care. But I typically copy-paste my UUIDs, and then > > > > 1. copy-pasting at the end is always faster than between > > the command and other arguments (3-args case). > > > > 2. copy-pasting the output of the previous command is faster > > than having one extra step where I need to copy the same thing twice > > (2-args case). > > > > So to me, if the script is intended to be used by humans, my > > proposal makes it slightly more comfortable to use. Nothing more. > > This is your preference, but I wouldn't call it universal. Specifying > the uuid last seems backwards to me, we're creating an object so let's > first name that object. We then specify where that object should be > created and what type it has. This seems very logical to me, besides, > it's also the exact same order we use when listing mdevs :P > > Clearly there's personal preference here, so let's not arbitrarily pick > a different preference. If copy/paste order is more important to you > then submit a patch to give mdevctl real argument processing so you can > specify --uuid, --parent, --type in whatever order you want. I agree that these are personal preferences :) Real argument processing makes sense, however.
next prev parent reply index Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-23 23:20 Alex Williamson 2019-05-24 10:11 ` Cornelia Huck 2019-05-24 14:43 ` Alex Williamson 2019-06-07 16:06 ` Halil Pasic 2019-06-11 19:45 ` Cornelia Huck 2019-06-11 20:28 ` Alex Williamson 2019-06-12 7:14 ` Cornelia Huck 2019-06-12 15:54 ` Halil Pasic 2019-06-13 10:02 ` Cornelia Huck 2019-06-12 15:07 ` Halil Pasic 2019-06-13 16:17 ` Christophe de Dinechin 2019-06-13 16:35 ` Alex Williamson 2019-06-14 9:54 ` [libvirt] " Christophe de Dinechin 2019-06-14 14:23 ` Alex Williamson 2019-06-14 15:06 ` Christophe de Dinechin 2019-06-14 16:04 ` Alex Williamson 2019-06-17 16:03 ` Cornelia Huck [this message] 2019-06-17 14:00 ` Daniel P. Berrangé 2019-06-17 14:54 ` Alex Williamson 2019-06-17 15:10 ` Daniel P. Berrangé 2019-06-17 17:05 ` Alex Williamson 2019-06-18 8:44 ` Daniel P. Berrangé 2019-06-18 11:01 ` Cornelia Huck [not found] ` <CALOCmukPWiXiM+mN0hCTvSwfdHy5UdERU8WnvOXiBrMQ9tH3VA@mail.gmail.com> 2019-06-18 22:12 ` Alex Williamson 2019-06-19 7:28 ` Daniel P. Berrangé 2019-06-19 9:46 ` Cornelia Huck 2019-06-19 18:46 ` Alex Williamson 2019-06-20 8:24 ` Daniel P. Berrangé [not found] ` <CALOCmu=6Xmw-_-SVXujCEcgPY2CQiBQKgfUMJ45WnZ_9XORyUw@mail.gmail.com> 2019-06-19 9:57 ` Cornelia Huck 2019-06-19 19:53 ` Alex Williamson 2019-06-25 22:52 ` Alex Williamson 2019-06-26 9:58 ` Cornelia Huck 2019-06-26 14:37 ` Alex Williamson 2019-06-27 1:53 ` Alex Williamson 2019-06-27 12:26 ` Cornelia Huck 2019-06-27 15:00 ` Matthew Rosato 2019-06-27 15:38 ` Alex Williamson 2019-06-27 16:13 ` Matthew Rosato 2019-06-27 21:15 ` Alex Williamson 2019-06-28 1:57 ` Alex Williamson 2019-06-28 9:06 ` Cornelia Huck 2019-06-28 14:01 ` Matthew Rosato 2019-06-28 17:05 ` Alex Williamson 2019-07-01 8:20 ` Cornelia Huck 2019-07-01 14:40 ` Alex Williamson 2019-07-01 17:13 ` Cornelia Huck
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ firstname.lastname@example.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git