From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB85BC31E5B for ; Mon, 17 Jun 2019 20:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B617D2085A for ; Mon, 17 Jun 2019 20:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727047AbfFQUHI (ORCPT ); Mon, 17 Jun 2019 16:07:08 -0400 Received: from mga03.intel.com ([134.134.136.65]:23679 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbfFQUHI (ORCPT ); Mon, 17 Jun 2019 16:07:08 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2019 13:07:01 -0700 X-ExtLoop1: 1 Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.36]) by fmsmga005.fm.intel.com with ESMTP; 17 Jun 2019 13:07:01 -0700 Date: Mon, 17 Jun 2019 13:07:01 -0700 From: Sean Christopherson To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, vkuznets@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH 22/43] KVM: nVMX: Don't dump VMCS if virtual APIC page can't be mapped Message-ID: <20190617200700.GA30158@linux.intel.com> References: <1560445409-17363-1-git-send-email-pbonzini@redhat.com> <1560445409-17363-23-git-send-email-pbonzini@redhat.com> <20190617191724.GA26860@flask> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190617191724.GA26860@flask> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 17, 2019 at 09:17:24PM +0200, Radim Krčmář wrote: > 2019-06-13 19:03+0200, Paolo Bonzini: > > From: Sean Christopherson > > > > ... as a malicious userspace can run a toy guest to generate invalid > > virtual-APIC page addresses in L1, i.e. flood the kernel log with error > > messages. > > > > Fixes: 690908104e39d ("KVM: nVMX: allow tests to use bad virtual-APIC page address") > > Cc: stable@vger.kernel.org > > Cc: Paolo Bonzini > > Signed-off-by: Sean Christopherson > > Signed-off-by: Paolo Bonzini > > --- > > Makes me wonder why it looks like this in kvm/queue. :) Presumably something is wonky in Paolo's workflow, this happened before. commit d69129b4e46a7b61dc956af038d143eb791f22c7 Author: Sean Christopherson Date: Wed May 8 07:32:15 2019 -0700 KVM: nVMX: Disable intercept for FS/GS base MSRs in vmcs02 when possible If L1 is using an MSR bitmap, unconditionally merge the MSR bitmaps from L0 and L1 for MSR_{KERNEL,}_{FS,GS}_BASE. KVM unconditionally exposes MSRs L1. If KVM is also running in L1 then it's highly likely L1 is also exposing the MSRs to L2, i.e. KVM doesn't need to intercept L2 accesses. Based on code from Jintack Lim. Cc: Jintack Lim Signed-off-by: Sean Christopherson Signed-off-by: Paolo Bonzini > > commit 1971a835297f9098ce5a735d38916830b8313a65 > Author: Sean Christopherson > AuthorDate: Tue May 7 09:06:26 2019 -0700 > Commit: Paolo Bonzini > CommitDate: Thu Jun 13 16:23:13 2019 +0200 > > KVM: nVMX: Don't dump VMCS if virtual APIC page can't be mapped > > ... as a malicious userspace can run a toy guest to generate invalid > virtual-APIC page addresses in L1, i.e. flood the kernel log with error > messages. > > Fixes: 690908104e39d ("KVM: nVMX: allow tests to use bad virtual-APIC page address") > Cc: stable@xxxxxxxxxxxxxxx > Cc: Paolo Bonzini > Signed-off-by: Sean Christopherson > Signed-off-by: Paolo Bonzini