From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBFBC43613 for ; Thu, 20 Jun 2019 12:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E84F2082C for ; Thu, 20 Jun 2019 12:43:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731831AbfFTMnJ (ORCPT ); Thu, 20 Jun 2019 08:43:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48462 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbfFTMnI (ORCPT ); Thu, 20 Jun 2019 08:43:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 87215307D866; Thu, 20 Jun 2019 12:43:07 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 470F95C205; Thu, 20 Jun 2019 12:43:02 +0000 (UTC) Date: Thu, 20 Jun 2019 14:42:57 +0200 From: Igor Mammedov To: Dongjiu Geng Cc: , , , , , , , , , , , , , , , Subject: Re: [PATCH v17 05/10] acpi: add build_append_ghes_generic_status() helper for Generic Error Status Block Message-ID: <20190620144257.7400b0a7@redhat.com> In-Reply-To: <1557832703-42620-6-git-send-email-gengdongjiu@huawei.com> References: <1557832703-42620-1-git-send-email-gengdongjiu@huawei.com> <1557832703-42620-6-git-send-email-gengdongjiu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 20 Jun 2019 12:43:07 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 14 May 2019 04:18:18 -0700 Dongjiu Geng wrote: > It will help to add Generic Error Status Block to ACPI tables > without using packed C structures and avoid endianness > issues as API doesn't need explicit conversion. > > Signed-off-by: Dongjiu Geng > --- > hw/acpi/aml-build.c | 14 ++++++++++++++ > include/hw/acpi/aml-build.h | 6 ++++++ > 2 files changed, 20 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 102a288..ce90970 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -296,6 +296,20 @@ void build_append_ghes_notify(GArray *table, const uint8_t type, > build_append_int_noprefix(table, error_threshold_window, 4); > } > > +/* Generic Error Status Block > + * ACPI 4.0: 17.3.2.6.1 Generic Error Data > + */ > +void build_append_ghes_generic_status(GArray *table, uint32_t block_status, maybe ..._generic_error_status??? > + uint32_t raw_data_offset, uint32_t raw_data_length, > + uint32_t data_length, uint32_t error_severity) see CODING_STYLE, 1.1 Multiline Indent > +{ when describing filds from spec try to add 'verbatim' copy of the name from spec so it would be esy to grep for it. Like: /* Block Status */ > + build_append_int_noprefix(table, block_status, 4); /* Raw Data Offset */ note applies all other places where you compose ACPI tables > + build_append_int_noprefix(table, raw_data_offset, 4); > + build_append_int_noprefix(table, raw_data_length, 4); > + build_append_int_noprefix(table, data_length, 4); > + build_append_int_noprefix(table, error_severity, 4); > +} > + > /* Generic Error Data Entry > * ACPI 4.0: 17.3.2.6.1 Generic Error Data > */ > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index a71db2f..1ec7e1b 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -425,6 +425,12 @@ void build_append_ghes_generic_data(GArray *table, const char *section_type, > uint32_t error_data_length, uint8_t *fru_id, > uint8_t *fru_text, uint64_t time_stamp); > > +void > +build_append_ghes_generic_status(GArray *table, uint32_t block_status, > + uint32_t raw_data_offset, > + uint32_t raw_data_length, > + uint32_t data_length, uint32_t error_severity); this and previous patch, it might be better to to move declaration to its own header, for example to include/hw/acpi/acpi_ghes.h that you are adding later in the series. And maybe move helpers to hw/acpi/acpi_ghes.c They are not really independent ACPI primitives that are shared with other tables, aren't they? . > + > void build_srat_memory(AcpiSratMemoryAffinity *numamem, uint64_t base, > uint64_t len, int node, MemoryAffinityFlags flags); >