kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Farhan Ali <alifm@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	Cornelia Huck <cohuck@redhat.com>
Subject: [PULL 06/14] vfio-ccw: Adjust the first IDAW outside of the nested loops
Date: Fri, 21 Jun 2019 16:33:47 +0200	[thread overview]
Message-ID: <20190621143355.29175-7-cohuck@redhat.com> (raw)
In-Reply-To: <20190621143355.29175-1-cohuck@redhat.com>

From: Eric Farman <farman@linux.ibm.com>

Now that pfn_array_table[] is always an array of 1, it seems silly to
check for the very first entry in an array in the middle of two nested
loops, since we know it'll only ever happen once.

Let's move this outside the loops to simplify things, even though
the "k" variable is still necessary.

Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20190606202831.44135-7-farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 drivers/s390/cio/vfio_ccw_cp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
index 86a0e76ef2b5..ab9f8f0d1b44 100644
--- a/drivers/s390/cio/vfio_ccw_cp.c
+++ b/drivers/s390/cio/vfio_ccw_cp.c
@@ -201,11 +201,12 @@ static inline void pfn_array_table_idal_create_words(
 		pa = pat->pat_pa + i;
 		for (j = 0; j < pa->pa_nr; j++) {
 			idaws[k] = pa->pa_pfn[j] << PAGE_SHIFT;
-			if (k == 0)
-				idaws[k] += pa->pa_iova & (PAGE_SIZE - 1);
 			k++;
 		}
 	}
+
+	/* Adjust the first IDAW, since it may not start on a page boundary */
+	idaws[0] += pat->pat_pa->pa_iova & (PAGE_SIZE - 1);
 }
 
 
-- 
2.20.1


  parent reply	other threads:[~2019-06-21 14:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 14:33 [PULL 00/14] more vfio-ccw updates for 5.3 Cornelia Huck
2019-06-21 14:33 ` [PULL 01/14] s390/cio: Squash cp_free() and cp_unpin_free() Cornelia Huck
2019-06-21 14:33 ` [PULL 02/14] s390/cio: Refactor the routine that handles TIC CCWs Cornelia Huck
2019-06-21 14:33 ` [PULL 03/14] s390/cio: Generalize the TIC handler Cornelia Huck
2019-06-21 14:33 ` [PULL 04/14] s390/cio: Use generalized CCW handler in cp_init() Cornelia Huck
2019-06-21 14:33 ` [PULL 05/14] vfio-ccw: Rearrange pfn_array and pfn_array_table arrays Cornelia Huck
2019-06-21 14:33 ` Cornelia Huck [this message]
2019-06-21 14:33 ` [PULL 07/14] vfio-ccw: Remove pfn_array_table Cornelia Huck
2019-06-21 19:13   ` Eric Farman
2019-06-21 14:33 ` [PULL 08/14] vfio-ccw: Rearrange IDAL allocation in direct CCW Cornelia Huck
2019-06-21 14:33 ` [PULL 09/14] s390/cio: Combine direct and indirect CCW paths Cornelia Huck
2019-06-21 14:33 ` [PULL 10/14] vfio-ccw: Move guest_cp storage into common struct Cornelia Huck
2019-06-21 14:33 ` [PULL 11/14] vfio-ccw: Skip second copy of guest cp to host Cornelia Huck
2019-06-21 14:33 ` [PULL 12/14] vfio-ccw: Copy CCW data outside length calculation Cornelia Huck
2019-06-21 14:33 ` [PULL 13/14] vfio-ccw: Factor out the ccw0-to-ccw1 transition Cornelia Huck
2019-06-21 19:13   ` Eric Farman
2019-06-22  8:38     ` Heiko Carstens
2019-06-21 14:33 ` [PULL 14/14] vfio-ccw: Remove copy_ccw_from_iova() Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621143355.29175-7-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=farman@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).