From: Cornelia Huck <cohuck@redhat.com>
To: Farhan Ali <alifm@linux.ibm.com>
Cc: farman@linux.ibm.com, pasic@linux.ibm.com,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC v2 1/5] vfio-ccw: Fix misleading comment when setting orb.cmd.c64
Date: Tue, 9 Jul 2019 11:57:33 +0200 [thread overview]
Message-ID: <20190709115733.40eb8db5.cohuck@redhat.com> (raw)
In-Reply-To: <25a5bf8ae538a392f8483e6fd4b9b165de40bfce.1562616169.git.alifm@linux.ibm.com>
On Mon, 8 Jul 2019 16:10:34 -0400
Farhan Ali <alifm@linux.ibm.com> wrote:
> The comment is misleading because it tells us that
> we should set orb.cmd.c64 before calling ccwchain_calc_length,
> otherwise the function ccwchain_calc_length would return an
> error. This is not completely accurate.
>
> We want to allow an orb without cmd.c64, and this is fine
> as long as the channel program does not use IDALs. But we do
> want to reject any channel program that uses IDALs and does
> not set the flag, which what we do in ccwchain_calc_length.
>
> After we have done the ccw processing, it should be safe
> to set cmd.c64, since we will convert them into IDALs.
"After we have done the ccw processing, we need to set cmd.c64, as we
use IDALs for all translated channel programs." ?
>
Fixes: fb9e7880af35 ("vfio: ccw: push down unsupported IDA check")
> Signed-off-by: Farhan Ali <alifm@linux.ibm.com>
> ---
> drivers/s390/cio/vfio_ccw_cp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
> index d6a8dff..7622b72 100644
> --- a/drivers/s390/cio/vfio_ccw_cp.c
> +++ b/drivers/s390/cio/vfio_ccw_cp.c
> @@ -645,8 +645,8 @@ int cp_init(struct channel_program *cp, struct device *mdev, union orb *orb)
> if (ret)
> cp_free(cp);
>
> - /* It is safe to force: if not set but idals used
> - * ccwchain_calc_length returns an error.
> + /* It is safe to force: if it was not set but idals used
> + * ccwchain_calc_length would have returned an error.
Thanks, much clearer.
> */
> cp->orb.cmd.c64 = 1;
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-07-09 9:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 20:10 [RFC v2 0/5] Some vfio-ccw fixes Farhan Ali
2019-07-08 20:10 ` [RFC v2 1/5] vfio-ccw: Fix misleading comment when setting orb.cmd.c64 Farhan Ali
2019-07-09 9:57 ` Cornelia Huck [this message]
2019-07-08 20:10 ` [RFC v2 2/5] vfio-ccw: Fix memory leak and don't call cp_free in cp_init Farhan Ali
2019-07-09 10:06 ` Cornelia Huck
2019-07-09 14:07 ` Farhan Ali
2019-07-09 14:18 ` Cornelia Huck
2019-07-08 20:10 ` [RFC v2 3/5] vfio-ccw: Set pa_nr to 0 if memory allocation fails for pa_iova_pfn Farhan Ali
2019-07-09 10:08 ` Cornelia Huck
2019-07-08 20:10 ` [RFC v2 4/5] vfio-ccw: Don't call cp_free if we are processing a channel program Farhan Ali
2019-07-09 10:16 ` Cornelia Huck
2019-07-09 13:46 ` Farhan Ali
2019-07-09 14:21 ` Halil Pasic
2019-07-09 21:27 ` Farhan Ali
2019-07-10 13:45 ` Cornelia Huck
2019-07-10 16:10 ` Farhan Ali
2019-07-11 12:28 ` Eric Farman
2019-07-11 14:57 ` Halil Pasic
2019-07-11 20:09 ` Eric Farman
2019-07-12 13:59 ` Halil Pasic
2019-07-08 20:10 ` [RFC v2 5/5] vfio-ccw: Update documentation for csch/hsch Farhan Ali
2019-07-09 10:14 ` Cornelia Huck
2019-07-09 12:47 ` Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709115733.40eb8db5.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).