From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEDA0C7618F for ; Mon, 15 Jul 2019 09:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1C1920868 for ; Mon, 15 Jul 2019 09:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729506AbfGOJCy (ORCPT ); Mon, 15 Jul 2019 05:02:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:44199 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729245AbfGOJCx (ORCPT ); Mon, 15 Jul 2019 05:02:53 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jul 2019 02:02:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,493,1557212400"; d="scan'208";a="365809173" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 15 Jul 2019 02:02:48 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id DF2ED14B; Mon, 15 Jul 2019 12:02:47 +0300 (EEST) Date: Mon, 15 Jul 2019 12:02:47 +0300 From: "Kirill A. Shutemov" To: Randy Dunlap , Alison Schofield Cc: Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , David Howells , Kees Cook , Dave Hansen , Kai Huang , Jacob Pan , linux-mm@kvack.org, kvm@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH, RFC 57/62] x86/mktme: Overview of Multi-Key Total Memory Encryption Message-ID: <20190715090247.lclzdru5gqowweis@black.fi.intel.com> References: <20190508144422.13171-1-kirill.shutemov@linux.intel.com> <20190508144422.13171-58-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170714-126-deb55f (1.8.3) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sun, Jul 14, 2019 at 06:16:49PM +0000, Randy Dunlap wrote: > On 5/8/19 7:44 AM, Kirill A. Shutemov wrote: > > From: Alison Schofield > > > > Provide an overview of MKTME on Intel Platforms. > > > > Signed-off-by: Alison Schofield > > Signed-off-by: Kirill A. Shutemov > > --- > > Documentation/x86/mktme/index.rst | 8 +++ > > Documentation/x86/mktme/mktme_overview.rst | 57 ++++++++++++++++++++++ > > 2 files changed, 65 insertions(+) > > create mode 100644 Documentation/x86/mktme/index.rst > > create mode 100644 Documentation/x86/mktme/mktme_overview.rst > > > > diff --git a/Documentation/x86/mktme/mktme_overview.rst b/Documentation/x86/mktme/mktme_overview.rst > > new file mode 100644 > > index 000000000000..59c023965554 > > --- /dev/null > > +++ b/Documentation/x86/mktme/mktme_overview.rst > > @@ -0,0 +1,57 @@ > > +Overview > > +========= > ... > > +-- > > +1. https://software.intel.com/sites/default/files/managed/a5/16/Multi-Key-Total-Memory-Encryption-Spec.pdf > > +2. The MKTME architecture supports up to 16 bits of KeyIDs, so a > > + maximum of 65535 keys on top of the “TME key” at KeyID-0. The > > + first implementation is expected to support 5 bits, making 63 > > Hi, > How do 5 bits make 63 keys available? Yep, typo. It has to be 6 bits. Alison, please correct this. -- Kirill A. Shutemov