From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5542DC7618F for ; Tue, 16 Jul 2019 16:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FFEB2054F for ; Tue, 16 Jul 2019 16:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728619AbfGPQKg (ORCPT ); Tue, 16 Jul 2019 12:10:36 -0400 Received: from mga03.intel.com ([134.134.136.65]:27268 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbfGPQKg (ORCPT ); Tue, 16 Jul 2019 12:10:36 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jul 2019 09:10:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,498,1557212400"; d="scan'208";a="158180063" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.165]) by orsmga007.jf.intel.com with ESMTP; 16 Jul 2019 09:10:35 -0700 Date: Tue, 16 Jul 2019 09:10:35 -0700 From: Sean Christopherson To: Liran Alon Cc: pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org, brijesh.singh@amd.com, Boris Ostrovsky Subject: Re: [PATCH 2/2] KVM: x86: Rename need_emulation_on_page_fault() to handle_no_insn_on_page_fault() Message-ID: <20190716161035.GB1987@linux.intel.com> References: <20190715203043.100483-1-liran.alon@oracle.com> <20190715203043.100483-3-liran.alon@oracle.com> <20190716154855.GA1987@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 16, 2019 at 07:01:30PM +0300, Liran Alon wrote: > > > On 16 Jul 2019, at 18:48, Sean Christopherson wrote: > > kvm_make_request(KVM_REQ_TRIPLE_FAULT, vcpu); > > return false; > > I don’t think we should triple-fault and return “false”. As from a semantic > perspective, we should return true. Fair enough, I guess it's no different than the warn-and-continue logic used in the unreachable VM-Exit handlers. > But this commit is getting really philosophical :) Maybe let’s hear Paolo’s > preference first before doing any change. Hence my recommendation to put the function change in a separate patch :-)