From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Nitesh Narayan Lal <nitesh@redhat.com>,
kvm list <kvm@vger.kernel.org>,
David Hildenbrand <david@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Yang Zhang <yang.zhang.wz@gmail.com>,
pagupta@redhat.com, Rik van Riel <riel@surriel.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
lcapitulino@redhat.com, wei.w.wang@intel.com,
Andrea Arcangeli <aarcange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
dan.j.williams@intel.com,
Alexander Duyck <alexander.h.duyck@linux.intel.com>
Subject: Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting
Date: Thu, 18 Jul 2019 16:24:15 -0400 [thread overview]
Message-ID: <20190718162040-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAKgT0UfQ3dtfjjm8wnNxX1+Azav6ws9zemH6KYc7RuyvyFo3fQ@mail.gmail.com>
On Thu, Jul 18, 2019 at 08:34:37AM -0700, Alexander Duyck wrote:
> > > > For example we allocate pages until shrinker kicks in.
> > > > Fair enough but in fact many it would be better to
> > > > do the reverse: trigger shrinker and then send as many
> > > > free pages as we can to host.
> > >
> > > I'm not sure I understand this last part.
> >
> > Oh basically what I am saying is this: one of the reasons to use page
> > hinting is when host is short on memory. In that case, why don't we use
> > shrinker to ask kernel drivers to free up memory? Any memory freed could
> > then be reported to host.
>
> Didn't the balloon driver already have a feature like that where it
> could start shrinking memory if the host was under memory pressure? If
> so how would adding another one add much value.
Well fundamentally the basic balloon inflate kind of does this, yes :)
The difference with what I am suggesting is that balloon inflate tries
to aggressively achieve a specific goal of freed memory. We could have a
weaker "free as much as you can" that is still stronger than free page
hint which as you point out below does not try to free at all, just
hints what is already free.
> The idea here is if the memory is free we just mark it as such. As
> long as we can do so with no noticeable overhead on the guest or host
> why not just do it?
next prev parent reply other threads:[~2019-07-18 20:24 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 22:32 [PATCH v1 0/6] mm / virtio: Provide support for paravirtual waste page treatment Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 1/6] mm: Adjust shuffle code to allow for future coalescing Alexander Duyck
2019-06-25 7:55 ` David Hildenbrand
2019-06-28 19:49 ` Alexander Duyck
2019-06-25 18:25 ` Dave Hansen
2019-06-25 18:26 ` Dave Hansen
2019-06-19 22:33 ` [PATCH v1 2/6] mm: Move set/get_pcppage_migratetype to mmzone.h Alexander Duyck
2019-06-25 18:28 ` Dave Hansen
2019-06-28 19:55 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 3/6] mm: Use zone and order instead of free area in free_list manipulators Alexander Duyck
2019-06-25 18:36 ` Dave Hansen
2019-06-19 22:33 ` [PATCH v1 4/6] mm: Introduce "aerated" pages Alexander Duyck
2019-06-25 19:45 ` Dave Hansen
2019-07-08 17:32 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 5/6] mm: Add logic for separating "aerated" pages from "raw" pages Alexander Duyck
2019-06-25 20:24 ` Dave Hansen
2019-07-08 19:02 ` Alexander Duyck
2019-07-08 19:36 ` Dave Hansen
2019-07-08 22:02 ` Alexander Duyck
2019-06-19 22:33 ` [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting Alexander Duyck
2019-07-16 9:55 ` Michael S. Tsirkin
2019-07-16 14:00 ` Dave Hansen
2019-07-16 14:12 ` David Hildenbrand
2019-07-16 14:17 ` David Hildenbrand
2019-07-16 15:04 ` Michael S. Tsirkin
2019-07-16 14:41 ` Dave Hansen
2019-07-16 15:01 ` Wang, Wei W
2019-07-16 16:12 ` Michael S. Tsirkin
2019-07-16 15:02 ` David Hildenbrand
2019-07-16 15:37 ` Alexander Duyck
2019-07-16 16:07 ` Michael S. Tsirkin
2019-07-16 16:54 ` Alexander Duyck
2019-07-16 17:41 ` Michael S. Tsirkin
2019-07-16 21:06 ` Alexander Duyck
2019-07-17 10:28 ` Michael S. Tsirkin
2019-07-17 16:43 ` Alexander Duyck
2019-07-18 5:13 ` Michael S. Tsirkin
2019-07-18 15:34 ` Alexander Duyck
2019-07-18 16:03 ` Nitesh Narayan Lal
2019-07-18 20:27 ` Michael S. Tsirkin
2019-07-18 16:07 ` Michael S. Tsirkin
2019-07-18 20:29 ` Alexander Duyck
2019-07-18 20:37 ` Michael S. Tsirkin
2019-07-18 20:54 ` Alexander Duyck
2019-07-18 20:24 ` Michael S. Tsirkin [this message]
2019-07-18 20:34 ` Alexander Duyck
2019-07-18 20:48 ` Michael S. Tsirkin
2019-07-18 21:09 ` Alexander Duyck
2019-06-19 22:37 ` [PATCH v1 QEMU] QEMU: Provide a interface for hinting based off of the balloon infrastructure Alexander Duyck
2019-06-25 7:42 ` [PATCH v1 0/6] mm / virtio: Provide support for paravirtual waste page treatment David Hildenbrand
2019-06-25 14:10 ` Dave Hansen
2019-06-25 17:00 ` Alexander Duyck
2019-06-25 18:12 ` David Hildenbrand
2019-06-25 18:22 ` Dave Hansen
2019-07-15 9:41 ` David Hildenbrand
2019-07-15 14:57 ` Alexander Duyck
2019-06-25 16:09 ` Alexander Duyck
2019-06-26 9:01 ` Christophe de Dinechin
2019-06-26 9:12 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718162040-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).