From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1A9C7618B for ; Thu, 25 Jul 2019 14:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47D7922C7D for ; Thu, 25 Jul 2019 14:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388840AbfGYO7t (ORCPT ); Thu, 25 Jul 2019 10:59:49 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43985 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388820AbfGYO7t (ORCPT ); Thu, 25 Jul 2019 10:59:49 -0400 Received: by mail-qt1-f194.google.com with SMTP id w17so5039873qto.10 for ; Thu, 25 Jul 2019 07:59:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Rmm6yLiguxnk1HEaBFpodRlU5b5ba8DS6Z2s5rRsdl0=; b=D+QKCDh/UmLzkSaglYZzTcWGx2nSewlFe6rY505tMzLf7bDcaRKkl2HqJuTae3BBPM 1ArAKj88LO39cary7OKoUWh+tFLIaNtfj7dD8NNquPHYbROe+Kaq1/RVNWng9BJcRVtA NOidcpYqKHodMExeXtz0UcQulFq82bSVBQ/iL2WqQTET2obI62JgGo/1RL/rJoFpEdIP UPoHT84b54WxcTmHeELy87Oasjfr1mE3s22H6a+gCTFZBOkLEvXQRKWCQ8cQZyg0EFvZ TLVDdi+Yda0rlJfG6Hv03v0VxQaKDJUZtiAhagKFD0gaGO8mhdVOK9b8WamCFDZS1Xn9 7/AA== X-Gm-Message-State: APjAAAXOqVDhFiTFuvi0eZPxaYEQP5BVg3uZxXAm1dIUeCHZSdw9E+/A cpSV8CJfs2WKGr66VLq0I0JOyA== X-Google-Smtp-Source: APXvYqzoIpindOeRtA1tCkHO4cy0qQv+nosyivtBgk+2pOYdPVUj3ArumomPLobNHAIjfwa4IloqWA== X-Received: by 2002:ac8:3907:: with SMTP id s7mr64407808qtb.374.1564066787847; Thu, 25 Jul 2019 07:59:47 -0700 (PDT) Received: from redhat.com (bzq-79-181-91-42.red.bezeqint.net. [79.181.91.42]) by smtp.gmail.com with ESMTPSA id v75sm24506057qka.38.2019.07.25.07.59.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 07:59:47 -0700 (PDT) Date: Thu, 25 Jul 2019 10:59:40 -0400 From: "Michael S. Tsirkin" To: Alexander Duyck Cc: Nitesh Narayan Lal , Alexander Duyck , kvm@vger.kernel.org, david@redhat.com, dave.hansen@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, yang.zhang.wz@gmail.com, pagupta@redhat.com, riel@surriel.com, konrad.wilk@oracle.com, lcapitulino@redhat.com, wei.w.wang@intel.com, aarcange@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com Subject: Re: [PATCH v2 5/5] virtio-balloon: Add support for providing page hints to host Message-ID: <20190725105852-mutt-send-email-mst@kernel.org> References: <20190724165158.6685.87228.stgit@localhost.localdomain> <20190724170514.6685.17161.stgit@localhost.localdomain> <20190724143902-mutt-send-email-mst@kernel.org> <21cc88cd-3577-e8b4-376f-26c7848f5764@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jul 25, 2019 at 07:56:15AM -0700, Alexander Duyck wrote: > On Thu, 2019-07-25 at 10:44 -0400, Nitesh Narayan Lal wrote: > > On 7/24/19 3:02 PM, Michael S. Tsirkin wrote: > > > On Wed, Jul 24, 2019 at 10:05:14AM -0700, Alexander Duyck wrote: > > > > From: Alexander Duyck > > > > > > > > Add support for the page hinting feature provided by virtio-balloon. > > > > Hinting differs from the regular balloon functionality in that is is > > > > much less durable than a standard memory balloon. Instead of creating a > > > > list of pages that cannot be accessed the pages are only inaccessible > > > > while they are being indicated to the virtio interface. Once the > > > > interface has acknowledged them they are placed back into their respective > > > > free lists and are once again accessible by the guest system. > > > > > > > > Signed-off-by: Alexander Duyck > > > Looking at the design, it seems that hinted pages can immediately be > > > reused. I wonder how we can efficiently support this > > > with kvm when poisoning is in effect. Of course we can just > > > ignore the poison. However it seems cleaner to > > > 1. verify page is poisoned with the correct value > > > 2. fill the page with the correct value on fault > > > > > > Requirement 2 requires some kind of madvise that > > > will save the poison e.g. in the VMA. > > > > > > Not a blocker for sure ... > > > > > > > > > > --- > > > > drivers/virtio/Kconfig | 1 + > > > > drivers/virtio/virtio_balloon.c | 47 +++++++++++++++++++++++++++++++++++ > > > > include/uapi/linux/virtio_balloon.h | 1 + > > > > 3 files changed, 49 insertions(+) > > > > > > > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > > > > index 078615cf2afc..d45556ae1f81 100644 > > > > --- a/drivers/virtio/Kconfig > > > > +++ b/drivers/virtio/Kconfig > > > > @@ -58,6 +58,7 @@ config VIRTIO_BALLOON > > > > tristate "Virtio balloon driver" > > > > depends on VIRTIO > > > > select MEMORY_BALLOON > > > > + select PAGE_HINTING > > > > ---help--- > > > > This driver supports increasing and decreasing the amount > > > > of memory within a KVM guest. > > > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > > > > index 226fbb995fb0..dee9f8f3ad09 100644 > > > > --- a/drivers/virtio/virtio_balloon.c > > > > +++ b/drivers/virtio/virtio_balloon.c > > > > @@ -19,6 +19,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > /* > > > > * Balloon device works in 4K page units. So each page is pointed to by > > > > @@ -27,6 +28,7 @@ > > > > */ > > > > #define VIRTIO_BALLOON_PAGES_PER_PAGE (unsigned)(PAGE_SIZE >> VIRTIO_BALLOON_PFN_SHIFT) > > > > #define VIRTIO_BALLOON_ARRAY_PFNS_MAX 256 > > > > +#define VIRTIO_BALLOON_ARRAY_HINTS_MAX 32 > > > > #define VIRTBALLOON_OOM_NOTIFY_PRIORITY 80 > > > > > > > > #define VIRTIO_BALLOON_FREE_PAGE_ALLOC_FLAG (__GFP_NORETRY | __GFP_NOWARN | \ > > > > @@ -46,6 +48,7 @@ enum virtio_balloon_vq { > > > > VIRTIO_BALLOON_VQ_DEFLATE, > > > > VIRTIO_BALLOON_VQ_STATS, > > > > VIRTIO_BALLOON_VQ_FREE_PAGE, > > > > + VIRTIO_BALLOON_VQ_HINTING, > > > > VIRTIO_BALLOON_VQ_MAX > > > > }; > > > > > > > > @@ -113,6 +116,10 @@ struct virtio_balloon { > > > > > > > > /* To register a shrinker to shrink memory upon memory pressure */ > > > > struct shrinker shrinker; > > > > + > > > > + /* Unused page hinting device */ > > > > + struct virtqueue *hinting_vq; > > > > + struct page_hinting_dev_info ph_dev_info; > > > > }; > > > > > > > > static struct virtio_device_id id_table[] = { > > > > @@ -152,6 +159,22 @@ static void tell_host(struct virtio_balloon *vb, struct virtqueue *vq) > > > > > > > > } > > > > > > > > +void virtballoon_page_hinting_react(struct page_hinting_dev_info *ph_dev_info, > > > > + unsigned int num_hints) > > > > +{ > > > > + struct virtio_balloon *vb = > > > > + container_of(ph_dev_info, struct virtio_balloon, ph_dev_info); > > > > + struct virtqueue *vq = vb->hinting_vq; > > > > + unsigned int unused; > > > > + > > > > + /* We should always be able to add these buffers to an empty queue. */ > > > > > > can be an out of memory condition, and then ... > > > > Do we need an error check here? > > > > For situations where this fails we should disable hinting completely, maybe? > > No. Instead I will just limit the capacity to no more than the vq size. > Doing that should allow us to avoid the out of memory issue here if I am > understanding things correctly. > > I'm assuming the allocation being referred to is alloc_indirect_split(), > if so then it looks like it can fail and then we just fall back to using > the vring.desc directly which will work for my purposes as long as I limit > the capacity of the scatterlist to no more than the size of the vring. > Right. And maybe tweak the GFP mask - no reason to try to allocate memory aggressively with just 1 element in flight. >