From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15ACCC433FF for ; Thu, 8 Aug 2019 08:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3F68214C6 for ; Thu, 8 Aug 2019 08:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732011AbfHHI3h (ORCPT ); Thu, 8 Aug 2019 04:29:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731677AbfHHI3h (ORCPT ); Thu, 8 Aug 2019 04:29:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29FD030A00AB; Thu, 8 Aug 2019 08:29:37 +0000 (UTC) Received: from gondolin (dhcp-192-181.str.redhat.com [10.33.192.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id A02C75C219; Thu, 8 Aug 2019 08:29:33 +0000 (UTC) Date: Thu, 8 Aug 2019 10:29:31 +0200 From: Cornelia Huck To: Parav Pandit Cc: "kvm@vger.kernel.org" , "wankhede@nvidia.com" , "linux-kernel@vger.kernel.org" , "alex.williamson@redhat.com" , "cjia@nvidia.com" Subject: Re: [PATCH v1 2/2] vfio/mdev: Removed unused and redundant API for mdev UUID Message-ID: <20190808102931.40c6b4ae.cohuck@redhat.com> In-Reply-To: References: <20190802065905.45239-1-parav@mellanox.com> <20190806141826.52712-1-parav@mellanox.com> <20190806141826.52712-3-parav@mellanox.com> <20190807112801.6b2ceb36.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 08 Aug 2019 08:29:37 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, 7 Aug 2019 16:33:11 +0000 Parav Pandit wrote: > > -----Original Message----- > > From: Cornelia Huck > > Sent: Wednesday, August 7, 2019 2:58 PM > > To: Parav Pandit > > Cc: kvm@vger.kernel.org; wankhede@nvidia.com; linux- > > kernel@vger.kernel.org; alex.williamson@redhat.com; cjia@nvidia.com > > Subject: Re: [PATCH v1 2/2] vfio/mdev: Removed unused and redundant API for > > mdev UUID > > > > On Tue, 6 Aug 2019 09:18:26 -0500 > > Parav Pandit wrote: > > > > > There is no single production driver who is interested in mdev device > > > uuid. Currently UUID is mainly used to derive a device name. > > > Additionally mdev device name is already available using core kernel > > > API dev_name(). > > > > Well, the mdev code actually uses the uuid to check for duplicates before > > registration with the driver core would fail... I'd just drop the two sentences > Yes, it does the check. But its mainly used to derive a device name. > And to ensure that there are no two devices with duplicate name, it compares with the uuid. > > Even this 16 bytes storage is redundant. > Subsequently, I will submit a patch to get rid of storing this 16 bytes of UUID too. > Because for duplicate name check, device name itself is pretty good enough. > > Since I ran out of time and rc-4 is going on, I differed the 3rd simplification patch. I'm not sure why we'd want to ditch the uuid; it's not like it is taking up huge amounts of space... and I see the device name being derived from the unique identifier that is the uuid, and not as the unique identifier itself. > > Commit message actually came from the thoughts of 3rd patch, but I see that without it, its not so intuitive. > > > talking about the device name, IMHO they don't really add useful information; > > but I'll leave that decision to the maintainers. > > > > > > > > Hence removed unused exported symbol. > > > > > > Signed-off-by: Parav Pandit > > > --- > > > Changelog: > > > v0->v1: > > > - Updated commit log to address comments from Cornelia > > > --- > > > drivers/vfio/mdev/mdev_core.c | 6 ------ > > > include/linux/mdev.h | 1 - > > > 2 files changed, 7 deletions(-) > > > > Reviewed-by: Cornelia Huck > Thanks for the review.