From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D85D9C32750 for ; Tue, 13 Aug 2019 16:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6B1720679 for ; Tue, 13 Aug 2019 16:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727035AbfHMQe5 (ORCPT ); Tue, 13 Aug 2019 12:34:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbfHMQe5 (ORCPT ); Tue, 13 Aug 2019 12:34:57 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF48E300D21F; Tue, 13 Aug 2019 16:34:56 +0000 (UTC) Received: from gondolin (dhcp-192-232.str.redhat.com [10.33.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D02A794BE; Tue, 13 Aug 2019 16:34:52 +0000 (UTC) Date: Tue, 13 Aug 2019 18:34:49 +0200 From: Cornelia Huck To: Parav Pandit Cc: Alex Williamson , Kirti Wankhede , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "cjia@nvidia.com" Subject: Re: [PATCH v2 0/2] Simplify mtty driver and mdev core Message-ID: <20190813183449.703b2bf2.cohuck@redhat.com> In-Reply-To: References: <20190802065905.45239-1-parav@mellanox.com> <20190808141255.45236-1-parav@mellanox.com> <20190808170247.1fc2c4c4@x1.home> <77ffb1f8-e050-fdf5-e306-0a81614f7a88@nvidia.com> <20190813085246.1d642ae5@x1.home> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 13 Aug 2019 16:34:56 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 13 Aug 2019 16:28:53 +0000 Parav Pandit wrote: > In bigger objective, I wanted to discuss post this cleanup patch, is to expand mdev to have more user friendly device names. Uh, what is unfriendly about uuids? > > Before we reach there, I should include a patch that eliminates storing UUID itself in the mdev_device. I do not think that's a great idea. A uuid is, well, a unique identifier. What's so bad about it that it should be eliminated? > > > Also, let's not > > overstate what this particular API callback provides, it's simply access to the > > uuid of the device, which is a fundamental property of a mediated device. > This fundamental property is available in form of device name already. Let me reiterate that the device name is a string containing a formatted uuid, not a uuid. > > > API was added simply to provide data abstraction, allowing the struct > > mdev_device to be opaque to vendor drivers. Thanks, > > > I get that part. I prefer to remove the UUID itself from the structure and therefore removing this API makes lot more sense? What I don't get is why you want to eliminate the uuid in the first place? Again, what's so bad about it?