From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
jmattson@redhat.com, ehabkost@redhat.com
Subject: Re: [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests
Date: Thu, 22 Aug 2019 14:44:40 -0400 [thread overview]
Message-ID: <20190822184440.GA9964@char.us.oracle.com> (raw)
In-Reply-To: <1566376002-17121-3-git-send-email-pbonzini@redhat.com>
On Wed, Aug 21, 2019 at 10:26:41AM +0200, Paolo Bonzini wrote:
> Even though it is preferrable to use SPEC_CTRL (represented by
> X86_FEATURE_AMD_SSBD) instead of VIRT_SPEC, VIRT_SPEC is always
> supported anyway because otherwise it would be impossible to
> migrate from old to new CPUs. Make this apparent in the
> result of KVM_GET_SUPPORTED_CPUID as well.
>
> While at it, reuse X86_FEATURE_* constants for the SVM leaf too.
>
> However, we need to hide the bit on Intel processors, so move
> the setting to svm_set_supported_cpuid.
>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thank you!
next prev parent reply other threads:[~2019-08-22 18:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:26 [PATCH v2 0/3] KVM: x86: fixes for speculation bug feature reporting Paolo Bonzini
2019-08-21 8:26 ` [PATCH 1/3] KVM: x86: fix reporting of AMD speculation bug CPUID leaf Paolo Bonzini
2019-08-21 19:45 ` Jim Mattson
2019-08-22 18:46 ` Konrad Rzeszutek Wilk
2019-11-30 23:27 ` Eric Biggers
2019-12-09 17:55 ` Eric Biggers
2019-12-13 22:27 ` Eduardo Habkost
2019-08-21 8:26 ` [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests Paolo Bonzini
2019-08-21 19:47 ` Jim Mattson
2019-08-22 18:44 ` Konrad Rzeszutek Wilk [this message]
2019-10-01 22:16 ` Eduardo Habkost
2019-10-06 16:08 ` Paolo Bonzini
2019-08-21 8:26 ` [PATCH 3/3] KVM: x86: use Intel speculation bugs and features as derived in generic x86 code Paolo Bonzini
2019-08-21 19:48 ` Jim Mattson
2019-08-22 18:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822184440.GA9964@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ehabkost@redhat.com \
--cc=jmattson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).