kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: Book3S HV: Define usage types for rmap array in guest memslot
Date: Fri, 23 Aug 2019 20:04:54 +1000	[thread overview]
Message-ID: <20190823100454.GA11357@blackberry> (raw)
In-Reply-To: <20190820061349.28995-1-sjitindarsingh@gmail.com>

On Tue, Aug 20, 2019 at 04:13:49PM +1000, Suraj Jitindar Singh wrote:
> The rmap array in the guest memslot is an array of size number of guest
> pages, allocated at memslot creation time. Each rmap entry in this array
> is used to store information about the guest page to which it
> corresponds. For example for a hpt guest it is used to store a lock bit,
> rc bits, a present bit and the index of a hpt entry in the guest hpt
> which maps this page. For a radix guest which is running nested guests
> it is used to store a pointer to a linked list of nested rmap entries
> which store the nested guest physical address which maps this guest
> address and for which there is a pte in the shadow page table.
> 
> As there are currently two uses for the rmap array, and the potential
> for this to expand to more in the future, define a type field (being the
> top 8 bits of the rmap entry) to be used to define the type of the rmap
> entry which is currently present and define two values for this field
> for the two current uses of the rmap array.
> 
> Since the nested case uses the rmap entry to store a pointer, define
> this type as having the two high bits set as is expected for a pointer.
> Define the hpt entry type as having bit 56 set (bit 7 IBM bit ordering).
> 
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>

Thanks, applied to my kvm-ppc-next branch.

Paul.

      reply	other threads:[~2019-08-23 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20  6:13 [PATCH] KVM: PPC: Book3S HV: Define usage types for rmap array in guest memslot Suraj Jitindar Singh
2019-08-23 10:04 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190823100454.GA11357@blackberry \
    --to=paulus@ozlabs.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=sjitindarsingh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).