From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB82C3A5A2 for ; Tue, 3 Sep 2019 07:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2ACE22053B for ; Tue, 3 Sep 2019 07:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727894AbfICHqA (ORCPT ); Tue, 3 Sep 2019 03:46:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41118 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725888AbfICHqA (ORCPT ); Tue, 3 Sep 2019 03:46:00 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0AA7C057E16 for ; Tue, 3 Sep 2019 07:45:59 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id c1so9979034wrb.12 for ; Tue, 03 Sep 2019 00:45:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=afLRR+Y6/XWNAyGbBu630m0eglXDmP7UhfuV7wpot38=; b=PNMY4wpCTd9KabDufyGlrDJxBLmPq0uuQTYBsWR6bqpq15k9jf5cdS0DA8UBXJY17/ 55nsf3F1lMkreZ5RQzGhx6UHGZQ0KKPDKv9LEhXfevjsw4AKVUR1jtUGv+scYXsWssGA +0hVimhIxQdxPgc/9ThutIlD5AYeVxUW+2gXrOBByKNCJnoyPQFRX2hJfue3ggzi5R0P QchDViTO+ivQpqC5gpgn/9DkhZB9IGSnqQmPsSfqrUeSMbsJHdnIjrffLKb1QgzZCC9m LQB2Vh7HnOCUBYNtONMknAlahlxsWZChp51uNb1kW4KEtymOHD/Ntw1xLvS+fn6Qfwa2 lFWg== X-Gm-Message-State: APjAAAWOkuIIUQIciP2UP71P5PP6bY4dg9lf53hC3IjKAxEL6Pq3KPkf 2NCTg96+FQ95jHsAJMzWkx/Wb/Yn29iqcqsdwmb25XEz4mIdtK+Rn0cG8gOnlzMd/gN6jRP/IfY rrgzlNMWOC3Ma X-Received: by 2002:a1c:984b:: with SMTP id a72mr15750245wme.149.1567496758381; Tue, 03 Sep 2019 00:45:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9640LTLNpf5tgrM8awc95gC1ytFwievAzkPz7D7FKlbtNZiw8m+0po4nQhhx9AFdnL0h8rA== X-Received: by 2002:a1c:984b:: with SMTP id a72mr15750224wme.149.1567496758176; Tue, 03 Sep 2019 00:45:58 -0700 (PDT) Received: from steredhat (host170-61-dynamic.36-79-r.retail.telecomitalia.it. [79.36.61.170]) by smtp.gmail.com with ESMTPSA id l62sm41378400wml.13.2019.09.03.00.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2019 00:45:57 -0700 (PDT) Date: Tue, 3 Sep 2019 09:45:54 +0200 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi , "David S. Miller" , virtualization@lists.linux-foundation.org, Jason Wang , kvm@vger.kernel.org Subject: Re: [PATCH v4 1/5] vsock/virtio: limit the memory used per-socket Message-ID: <20190903074554.mq6spyivftuodahy@steredhat> References: <20190729143622-mutt-send-email-mst@kernel.org> <20190730093539.dcksure3vrykir3g@steredhat> <20190730163807-mutt-send-email-mst@kernel.org> <20190801104754.lb3ju5xjfmnxioii@steredhat> <20190801091106-mutt-send-email-mst@kernel.org> <20190801133616.sik5drn6ecesukbb@steredhat> <20190901025815-mutt-send-email-mst@kernel.org> <20190901061707-mutt-send-email-mst@kernel.org> <20190902095723.6vuvp73fdunmiogo@steredhat> <20190903003823-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903003823-mutt-send-email-mst@kernel.org> User-Agent: NeoMutt/20180716 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 03, 2019 at 12:39:19AM -0400, Michael S. Tsirkin wrote: > On Mon, Sep 02, 2019 at 11:57:23AM +0200, Stefano Garzarella wrote: > > > > > > Assuming we miss nothing and buffers < 4K are broken, > > > I think we need to add this to the spec, possibly with > > > a feature bit to relax the requirement that all buffers > > > are at least 4k in size. > > > > > > > Okay, should I send a proposal to virtio-dev@lists.oasis-open.org? > > How about we also fix the bug for now? This series unintentionally fix the bug because we are introducing a way to split the packet depending on the buffer size ([PATCH 4/5] vhost/vsock: split packets to send using multiple buffers) and we removed the limit to 4K buffers ([PATCH 5/5] vsock/virtio: change the maximum packet size allowed). I discovered that there was a bug while we discussed memory accounting. Do you think it's enough while we introduce the feature bit in the spec? Thanks, Stefano