KVM Archive on lore.kernel.org
 help / color / Atom feed
* [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier
@ 2019-09-09 21:28 Bill Wendling
  2019-09-10 16:44 ` Jim Mattson
  2019-09-11 19:11 ` Sean Christopherson
  0 siblings, 2 replies; 3+ messages in thread
From: Bill Wendling @ 2019-09-09 21:28 UTC (permalink / raw)
  To: kvm

The extended assembly documentation list only "q" as an operand modifier
for DImode registers. The "d" seems to be an AMD-ism, which appears to
be only begrudgingly supported by gcc.

Signed-off-by: Bill Wendling <morbo@google.com>
---
 x86/emulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/x86/emulator.c b/x86/emulator.c
index b132b90..621caf9 100644
--- a/x86/emulator.c
+++ b/x86/emulator.c
@@ -799,7 +799,7 @@ static void test_smsw_reg(uint64_t *mem)
  asm(KVM_FEP "smswl %k0\n\t" : "=a" (rax) : "0" (in_rax));
  report("32-bit smsw reg", rax == (u32)cr0);

- asm(KVM_FEP "smswq %d0\n\t" : "=a" (rax) : "0" (in_rax));
+ asm(KVM_FEP "smswq %q0\n\t" : "=a" (rax) : "0" (in_rax));
  report("64-bit smsw reg", rax == cr0);
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier
  2019-09-09 21:28 [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier Bill Wendling
@ 2019-09-10 16:44 ` Jim Mattson
  2019-09-11 19:11 ` Sean Christopherson
  1 sibling, 0 replies; 3+ messages in thread
From: Jim Mattson @ 2019-09-10 16:44 UTC (permalink / raw)
  To: Bill Wendling; +Cc: kvm list

On Mon, Sep 9, 2019 at 2:28 PM Bill Wendling <morbo@google.com> wrote:
>
> The extended assembly documentation list only "q" as an operand modifier
> for DImode registers. The "d" seems to be an AMD-ism, which appears to
> be only begrudgingly supported by gcc.
>
> Signed-off-by: Bill Wendling <morbo@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier
  2019-09-09 21:28 [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier Bill Wendling
  2019-09-10 16:44 ` Jim Mattson
@ 2019-09-11 19:11 ` Sean Christopherson
  1 sibling, 0 replies; 3+ messages in thread
From: Sean Christopherson @ 2019-09-11 19:11 UTC (permalink / raw)
  To: Bill Wendling; +Cc: kvm

On Mon, Sep 09, 2019 at 02:28:22PM -0700, Bill Wendling wrote:
> The extended assembly documentation list only "q" as an operand modifier
> for DImode registers. The "d" seems to be an AMD-ism, which appears to
> be only begrudgingly supported by gcc.
> 
> Signed-off-by: Bill Wendling <morbo@google.com>
> ---

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 21:28 [kvm-unit-tests PATCH] x86: emulator: use "q" operand modifier Bill Wendling
2019-09-10 16:44 ` Jim Mattson
2019-09-11 19:11 ` Sean Christopherson

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org kvm@archiver.kernel.org
	public-inbox-index kvm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox