From: Aaron Lewis <aaronlewis@google.com>
To: Babu Moger <Babu.Moger@amd.com>,
Yang Weijiang <weijiang.yang@intel.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
Aaron Lewis <aaronlewis@google.com>
Subject: [PATCH v2 0/5] Add support for XSAVES on AMD and unify it with Intel
Date: Fri, 11 Oct 2019 12:40:27 -0700 [thread overview]
Message-ID: <20191011194032.240572-1-aaronlewis@google.com> (raw)
Unify AMD's and Intel's approach for supporting XSAVES. To do this
change Intel's approach from using the MSR-load areas to writing
the guest/host values to IA32_XSS on a VM-enter/VM-exit. Switching to
this strategy allows for a common approach between both AMD and Intel.
Additionally, define svm_xsaves_supported() based on AMD's feedback, and
add IA32_XSS to the emulated_msrs list, in preparation for the day when
the guest IA32_XSS may contain a non-zero value.
This change sets up IA32_XSS to be a non-zero value in the future, which
may happen sooner than later with support for guest CET feature being
added.
v1 -> v2:
- Add the flag xsaves_enabled to kvm_vcpu_arch to track when XSAVES is
enabled in the guest, whether or not XSAVES is enumerated in the
guest CPUID.
- Remove code that sets the X86_FEATURE_XSAVES bit in the guest CPUID
which was added in patch "Enumerate XSAVES in guest CPUID when it is
available to the guest". As a result we no longer need that patch.
- Added a comment to kvm_set_msr_common to describe how to save/restore
PT MSRS without using XSAVES/XRSTORS.
- Added more comments to the "Add support for XSAVES on AMD" patch.
- Replaced vcpu_set_msr_expect_result() with _vcpu_set_msr() in the
test library.
Aaron Lewis (5):
KVM: VMX: Remove unneeded check for X86_FEATURE_XSAVE
KVM: VMX: Use wrmsr for switching between guest and host IA32_XSS
kvm: svm: Add support for XSAVES on AMD
kvm: x86: Add IA32_XSS to the emulated_msrs list
kvm: tests: Add test to verify MSR_IA32_XSS
arch/x86/include/asm/kvm_host.h | 1 +
arch/x86/kvm/svm.c | 19 +++--
arch/x86/kvm/vmx/vmx.c | 46 ++++--------
arch/x86/kvm/x86.c | 46 ++++++++++--
arch/x86/kvm/x86.h | 4 +-
tools/testing/selftests/kvm/.gitignore | 1 +
tools/testing/selftests/kvm/Makefile | 1 +
.../selftests/kvm/include/x86_64/processor.h | 7 +-
.../selftests/kvm/lib/x86_64/processor.c | 72 ++++++++++++++++---
.../selftests/kvm/x86_64/xss_msr_test.c | 70 ++++++++++++++++++
10 files changed, 210 insertions(+), 57 deletions(-)
create mode 100644 tools/testing/selftests/kvm/x86_64/xss_msr_test.c
--
2.23.0.700.g56cf767bdb-goog
next reply other threads:[~2019-10-11 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 19:40 Aaron Lewis [this message]
2019-10-11 19:40 ` [PATCH v2 1/5] KVM: VMX: Remove unneeded check for X86_FEATURE_XSAVE Aaron Lewis
2019-10-11 19:40 ` [PATCH v2 2/5] KVM: VMX: Use wrmsr for switching between guest and host IA32_XSS Aaron Lewis
2019-10-12 0:18 ` Sean Christopherson
2019-10-12 17:36 ` Jim Mattson
2019-10-14 19:05 ` Sean Christopherson
2019-10-14 21:01 ` Jim Mattson
2019-10-14 23:55 ` Sean Christopherson
2019-10-11 19:40 ` [PATCH v2 3/5] kvm: svm: Add support for XSAVES on AMD Aaron Lewis
2019-10-11 19:40 ` [PATCH v2 4/5] kvm: x86: Add IA32_XSS to the emulated_msrs list Aaron Lewis
2019-10-11 19:40 ` [PATCH v2 5/5] kvm: tests: Add test to verify MSR_IA32_XSS Aaron Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011194032.240572-1-aaronlewis@google.com \
--to=aaronlewis@google.com \
--cc=Babu.Moger@amd.com \
--cc=bigeasy@linutronix.de \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=weijiang.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).