From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: kvm@vger.kernel.org
Cc: alex.williamson@redhat.com, kwankhede@nvidia.com,
kevin.tian@intel.com, cohuck@redhat.com
Subject: [PATCH 3/6] vfio/mdev: Add "aggregated_instances" attribute for supported mdev device
Date: Thu, 24 Oct 2019 13:08:26 +0800 [thread overview]
Message-ID: <20191024050829.4517-4-zhenyuw@linux.intel.com> (raw)
In-Reply-To: <20191024050829.4517-1-zhenyuw@linux.intel.com>
For mdev device created by "aggregate" parameter, this creates new mdev
device attribute "aggregated_instances" to show number of aggregated
instances allocated.
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
---
v2:
- change attribute name as "aggregated_instances"
v3:
- create only for aggregated allocation
v4:
- fix remove
drivers/vfio/mdev/mdev_sysfs.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index acd3ec2900b5..f131480a767a 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -289,6 +289,17 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR_WO(remove);
+static ssize_t
+aggregated_instances_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct mdev_device *mdev = to_mdev_device(dev);
+ return sprintf(buf, "%u\n", mdev->type_instances);
+}
+
+static DEVICE_ATTR_RO(aggregated_instances);
+
static const struct attribute *mdev_device_attrs[] = {
&dev_attr_remove.attr,
NULL,
@@ -296,6 +307,7 @@ static const struct attribute *mdev_device_attrs[] = {
int mdev_create_sysfs_files(struct device *dev, struct mdev_type *type)
{
+ struct mdev_device *mdev = to_mdev_device(dev);
int ret;
ret = sysfs_create_link(type->devices_kobj, &dev->kobj, dev_name(dev));
@@ -310,8 +322,17 @@ int mdev_create_sysfs_files(struct device *dev, struct mdev_type *type)
if (ret)
goto create_files_failed;
+ if (mdev->type_instances > 1) {
+ ret = sysfs_create_file(&dev->kobj,
+ &dev_attr_aggregated_instances.attr);
+ if (ret)
+ goto create_aggregated_failed;
+ }
+
return ret;
+create_aggregated_failed:
+ sysfs_remove_files(&dev->kobj, mdev_device_attrs);
create_files_failed:
sysfs_remove_link(&dev->kobj, "mdev_type");
type_link_failed:
@@ -321,6 +342,10 @@ int mdev_create_sysfs_files(struct device *dev, struct mdev_type *type)
void mdev_remove_sysfs_files(struct device *dev, struct mdev_type *type)
{
+ struct mdev_device *mdev = to_mdev_device(dev);
+ if (mdev->type_instances > 1)
+ sysfs_remove_file(&dev->kobj,
+ &dev_attr_aggregated_instances.attr);
sysfs_remove_files(&dev->kobj, mdev_device_attrs);
sysfs_remove_link(&dev->kobj, "mdev_type");
sysfs_remove_link(type->devices_kobj, dev_name(dev));
--
2.24.0.rc0
next prev parent reply other threads:[~2019-10-24 5:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 5:08 [PATCH 0/6] VFIO mdev aggregated resources handling Zhenyu Wang
2019-10-24 5:08 ` [PATCH 1/6] vfio/mdev: Add new "aggregate" parameter for mdev create Zhenyu Wang
2019-10-24 5:08 ` [PATCH 2/6] vfio/mdev: Add "aggregation" attribute for supported mdev type Zhenyu Wang
2019-10-27 6:24 ` kbuild test robot
2019-10-27 6:24 ` [RFC PATCH] vfio/mdev: mdev_type_attr_aggregation can be static kbuild test robot
2019-10-24 5:08 ` Zhenyu Wang [this message]
2019-10-24 5:08 ` [PATCH 4/6] Documentation/driver-api/vfio-mediated-device.rst: Update for vfio/mdev aggregation support Zhenyu Wang
2019-10-24 5:08 ` [PATCH 5/6] Documentation/ABI/testing/sysfs-bus-vfio-mdev: " Zhenyu Wang
2019-10-24 5:08 ` [PATCH 6/6] drm/i915/gvt: Add new type with " Zhenyu Wang
2019-11-05 21:10 ` [PATCH 0/6] VFIO mdev aggregated resources handling Alex Williamson
2019-11-06 4:20 ` Zhenyu Wang
2019-11-06 18:44 ` Alex Williamson
2019-11-07 13:02 ` Cornelia Huck
2019-11-15 4:24 ` Tian, Kevin
2019-11-19 22:58 ` Alex Williamson
2019-11-20 0:46 ` Tian, Kevin
2019-11-07 20:37 ` Parav Pandit
2019-11-08 8:19 ` Zhenyu Wang
2019-12-04 17:36 ` Parav Pandit
2019-12-05 6:06 ` Zhenyu Wang
2019-12-05 6:40 ` Jason Wang
2019-12-05 19:02 ` Parav Pandit
2019-12-05 18:59 ` Parav Pandit
2019-12-06 8:03 ` Zhenyu Wang
2019-12-06 17:33 ` Parav Pandit
2019-12-10 3:33 ` Tian, Kevin
2019-12-10 19:07 ` Alex Williamson
2019-12-10 21:08 ` Parav Pandit
2019-12-10 22:08 ` Alex Williamson
2019-12-10 22:40 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024050829.4517-4-zhenyuw@linux.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).