From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00599CA9EC6 for ; Wed, 30 Oct 2019 09:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C888421734 for ; Wed, 30 Oct 2019 09:51:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TNmxKRuU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbfJ3JvI (ORCPT ); Wed, 30 Oct 2019 05:51:08 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49468 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbfJ3JvI (ORCPT ); Wed, 30 Oct 2019 05:51:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OgRxbCfAHxinV36dhWY68cyg0aHWfYWs+JDbsLBkpXc=; b=TNmxKRuUgxEdcgw1cX0dRzsu8 NQnfFSwz4Ef9oEp+nKqSlCjD1ROMI7RtfJoKEXhOdhApo77rk3OrbQgLyhXcp2nuSa3wsW7s4Jv2f njoxYxTceE/DfWbyHnruLRYCYehWMYhbqN02g7krHsPDe+bWsZsfJ1kLEOUdMUb2cOBvj6QCTeop+ WTHmvCSqcONdob1c3POZG2T8tYtH5UnAEjeg9uLrnGEGhwmTCg/RaJ2Mryx5lyRisfsIzuk8EJn9O JBHLWcVu8ZyaPAJoMjrmMXZxFd9YVosBCVXUYGhuVSNP0ypMBiN7s2qgilJJAlZHirT6v28kP/SM/ xltWyXj7g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPkcd-0006zw-1E; Wed, 30 Oct 2019 09:50:35 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 87602306A7E; Wed, 30 Oct 2019 10:49:30 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A66742B4574F1; Wed, 30 Oct 2019 10:50:31 +0100 (CET) Date: Wed, 30 Oct 2019 10:50:31 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: "Kang, Luwei" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pbonzini@redhat.com" , "rkrcmar@redhat.com" , "Christopherson, Sean J" , "vkuznets@redhat.com" , "wanpengli@tencent.com" , "jmattson@google.com" , "joro@8bytes.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "x86@kernel.org" , "ak@linux.intel.com" , "thomas.lendacky@amd.com" , "acme@kernel.org" , "mark.rutland@arm.com" , "jolsa@redhat.com" , "namhyung@kernel.org" Subject: Re: [PATCH v1 3/8] KVM: x86: Allocate performance counter for PEBS event Message-ID: <20191030095031.GR4097@hirez.programming.kicks-ass.net> References: <1572217877-26484-1-git-send-email-luwei.kang@intel.com> <1572217877-26484-4-git-send-email-luwei.kang@intel.com> <20191029144612.GK4097@hirez.programming.kicks-ass.net> <82D7661F83C1A047AF7DC287873BF1E173835B1A@SHSMSX104.ccr.corp.intel.com> <87o8xyg2f1.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o8xyg2f1.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Oct 30, 2019 at 08:42:10AM +0200, Alexander Shishkin wrote: > "Kang, Luwei" writes: > > >> > static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type, > >> > unsigned config, bool exclude_user, > >> > bool exclude_kernel, bool intr, > >> > - bool in_tx, bool in_tx_cp) > >> > + bool in_tx, bool in_tx_cp, bool pebs) > >> > { > >> > struct perf_event *event; > >> > struct perf_event_attr attr = { > >> > @@ -111,9 +111,12 @@ static void pmc_reprogram_counter(struct kvm_pmc *pmc, u32 type, > >> > .exclude_user = exclude_user, > >> > .exclude_kernel = exclude_kernel, > >> > .config = config, > >> > + .precise_ip = pebs ? 1 : 0, > >> > + .aux_output = pebs ? 1 : 0, > >> > >> srsly? > > > > Hi Peter, > > Thanks for review. For aux_output, I think it should be set 1 when the guest wants to enabled PEBS by Intel PT. > > attr.aux_output==1 means your group leader should be an intel_pt event > for this to succeed. Luckily for this instance, > perf_event_create_kernel_counter() doesn't actually check the > attr.aux_output. > > Also, does 'bool pebs' mean PEBS-via-PT or just a PEBS counter? Or does > it mean that in kvm it's the same thing? It means pebs-over-pt, they only allow pebs if the output to pt bit is set.