From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE04FA372C for ; Fri, 8 Nov 2019 15:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 834F621882 for ; Fri, 8 Nov 2019 15:28:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SOCxnQ4n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726670AbfKHP2l (ORCPT ); Fri, 8 Nov 2019 10:28:41 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55602 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726039AbfKHP2l (ORCPT ); Fri, 8 Nov 2019 10:28:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573226920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QBNaeRqVhOTuFGhH+r1/YHHaqfBgjb8zMTl6JtH3Jw=; b=SOCxnQ4nbu04HJc+YyrULLNJsNG068lzDViJQN+ahrW1rZf6z7vrBgnyV1NFhaMb5hGyIx Lhhp5vZCichQj4oxavrio1N+vOwVhCee5Joj5QewYBNFsQEmdvbQT52mfPhym+9wkg78Ks dQqy9zRkCv5w/pV56qIgKyha1Mrpi7w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-BlfJgfpqPlCRIFNN-hdLvQ-1; Fri, 08 Nov 2019 10:28:36 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 607CF180496F; Fri, 8 Nov 2019 15:28:35 +0000 (UTC) Received: from gondolin (dhcp-192-218.str.redhat.com [10.33.192.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 053EE50; Fri, 8 Nov 2019 15:28:30 +0000 (UTC) Date: Fri, 8 Nov 2019 16:28:28 +0100 From: Cornelia Huck To: Parav Pandit Cc: "alex.williamson@redhat.com" , "davem@davemloft.net" , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" , Saeed Mahameed , "kwankhede@nvidia.com" , "leon@kernel.org" , Jiri Pirko , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH net-next 19/19] mtty: Optionally support mtty alias Message-ID: <20191108162828.6e12fc05.cohuck@redhat.com> In-Reply-To: References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-19-parav@mellanox.com> <20191108144615.3646e9bb.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: BlfJgfpqPlCRIFNN-hdLvQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 8 Nov 2019 15:10:42 +0000 Parav Pandit wrote: > > -----Original Message----- > > From: Cornelia Huck > > Sent: Friday, November 8, 2019 7:46 AM > > To: Parav Pandit > > Cc: alex.williamson@redhat.com; davem@davemloft.net; > > kvm@vger.kernel.org; netdev@vger.kernel.org; Saeed Mahameed > > ; kwankhede@nvidia.com; leon@kernel.org; Jiri > > Pirko ; linux-rdma@vger.kernel.org > > Subject: Re: [PATCH net-next 19/19] mtty: Optionally support mtty alias > >=20 > > On Thu, 7 Nov 2019 10:08:34 -0600 > > Parav Pandit wrote: > > =20 > > > Provide a module parameter to set alias length to optionally generate > > > mdev alias. > > > > > > Example to request mdev alias. > > > $ modprobe mtty alias_length=3D12 > > > > > > Make use of mtty_alias() API when alias_length module parameter is se= t. > > > > > > Signed-off-by: Parav Pandit > > > --- > > > samples/vfio-mdev/mtty.c | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) =20 > >=20 > > If you already have code using the alias interface, you probably don't = need > > to add it to the sample driver here. Especially as the alias looks kind= of > > pointless here. =20 >=20 > It is pointless. > Alex point when we ran through the series in August, was, QA should be ab= le to do cover coverage of mdev_core where there is mdev collision and mdev= _create() can fail. > And QA should be able to set alias length to be short to 1 or 2 letters t= o trigger it. > Hence this patch was added. If we want this for testing purposes, that should be spelled out explicitly (the above had already dropped from my cache). Even better if we had something in actual test infrastructure.