From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C580FA372C for ; Fri, 8 Nov 2019 18:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 533C621848 for ; Fri, 8 Nov 2019 18:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="uk8UaAdZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729688AbfKHSQM (ORCPT ); Fri, 8 Nov 2019 13:16:12 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36746 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbfKHSQL (ORCPT ); Fri, 8 Nov 2019 13:16:11 -0500 Received: by mail-wm1-f66.google.com with SMTP id c22so7195149wmd.1 for ; Fri, 08 Nov 2019 10:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lE8FBOSfE/g2hakn5G6bGrc07Q8RE7Tck3x5/3Imhks=; b=uk8UaAdZntNxSVFyBrPO3VFjFg5DX0vxBcQCJ7GIIvVTfRE9SMw9f4OqPDuv0hzNGK IARFXxXfJeOIRjBvr/vlBRafKoexTXEll+9wIHDKEVoB/qpKwCLwSEgUkmg+k71wS0GG AzvldGkGefX3mmpLk2rzWYApHVXVr18j7ImqNrDJ8SnPRT95sHp5AwN42QvnphScfgOz OW9X/BgbbHur9Tfb8BRMb3BSHM3zKdYvmJt411J5D2WdU5JNoPlWAucKanqZRXCe4cqK ErCSjPWaQZw9SHJwe9TGmuo+U2ZQt5RO4UpXGOIkHhJIavHf/5gIQGqNEMAPAhDx2dhR TdIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lE8FBOSfE/g2hakn5G6bGrc07Q8RE7Tck3x5/3Imhks=; b=c+FZ4knhdx/dtnN3iNONeQBkdrNaUU1d3hncMWvE71W3lbrMY5Ft7LzuEiyYH4yqbw BCs5KKXAzI0kl6KWd8vzWL547s9R0yHFGHuLPORKPBtIGNUGuAAD93YQGe5+wgisPh0I xpy8htMG7JNKj4zFaOfnZoUl+X80h/Xjk9WdnRUD3hFkzop5WhIueinYbGGNvShsxg6Z UQkvdRtw0520mJ/BMJQQLS8lvT72pU4l0hKejZN/IKxEluG4yc0vdVzvoOjFrpPJ0rTj U5X+IJnOWjffnyx96NAcLKhtMI/OtPiCZXQ2hTJWFCP8ZSA+/jzZsq4avvspmyQ/g1Gz rQbA== X-Gm-Message-State: APjAAAUr99yZcynE4t2rc/GCbB/Pm+viqCGPZpCZbjO9C2KIgZOKannP e8tLwYSH9azmS8UX4JpSC8D6eQ== X-Google-Smtp-Source: APXvYqzCguYwJ6szFdkczpR790kRZFo69/nmMpT+ShM3O+MqiuYvFJN2kS6shP6itI6ZaNYrVJc0vQ== X-Received: by 2002:a1c:f210:: with SMTP id s16mr8513157wmc.24.1573236969351; Fri, 08 Nov 2019 10:16:09 -0800 (PST) Received: from localhost (ip-94-113-220-175.net.upcbroadband.cz. [94.113.220.175]) by smtp.gmail.com with ESMTPSA id x9sm6458681wru.32.2019.11.08.10.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 10:16:09 -0800 (PST) Date: Fri, 8 Nov 2019 19:16:08 +0100 From: Jiri Pirko To: Alex Williamson Cc: Parav Pandit , davem@davemloft.net, kvm@vger.kernel.org, netdev@vger.kernel.org, saeedm@mellanox.com, kwankhede@nvidia.com, leon@kernel.org, cohuck@redhat.com, jiri@mellanox.com, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next 09/19] vfio/mdev: Expose mdev alias in sysfs tree Message-ID: <20191108181608.GV6990@nanopsycho> References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-9-parav@mellanox.com> <20191108132230.GK6990@nanopsycho> <20191108110355.77128e6f@x1.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108110355.77128e6f@x1.home> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Fri, Nov 08, 2019 at 07:03:55PM CET, alex.williamson@redhat.com wrote: >On Fri, 8 Nov 2019 14:22:30 +0100 >Jiri Pirko wrote: > >> Thu, Nov 07, 2019 at 05:08:24PM CET, parav@mellanox.com wrote: >> >> [...] >> >> > >> >+static ssize_t alias_show(struct device *device, >> >+ struct device_attribute *attr, char *buf) >> >+{ >> >+ struct mdev_device *dev = mdev_from_dev(device); >> >+ >> >+ if (!dev->alias) >> >+ return -EOPNOTSUPP; >> >+ >> >+ return sprintf(buf, "%s\n", dev->alias); >> >+} >> >+static DEVICE_ATTR_RO(alias); >> >> I wonder, rather than adding another sysfs file, why the alias can't be >> simply a symlink to the aliased mdev directory? > >The user doesn't know the alias in advance, it seems problematic to >assume an arbitrarily named link is the alias. Thanks, Why the user have to know in advance? > >Alex > >> >+ >> > static const struct attribute *mdev_device_attrs[] = { >> >+ &dev_attr_alias.attr, >> > &dev_attr_remove.attr, >> > NULL, >> > }; >> >-- >> >2.19.2 >> > >