From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259BFC43215 for ; Thu, 21 Nov 2019 08:09:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0EE720855 for ; Thu, 21 Nov 2019 08:09:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QrQsgxKv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbfKUII7 (ORCPT ); Thu, 21 Nov 2019 03:08:59 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42936 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfKUII6 (ORCPT ); Thu, 21 Nov 2019 03:08:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OcpTi94GnRpnsNJ6x/sOFat0nuNLJDLsOgN2tOaB1sQ=; b=QrQsgxKvVCngpF9wwToJ87iIc t07EM61S14tQ6LTSMJ6Lo68A7lTgQiTaMJ7XyPH6GXi3L9Sn0UMAanSAgoh7k0JuD5ej8hfhbdwcV CQ8zOB+GC79NwciMufbTiMmuqSE8yw3laqw81gptK9LnxglLyql2dZmlIq6Qh/WUoXhwX39cagAps FcTK3fD64clmn6r29XPEIQyTz7eYXzYLBp7YNuMhI1VzlCBjyFarXn7vq+R9A49PezzNZCZxjkOYx jP+d6+/bMMfCu1P6l922Kg/tH6Mft7oJUg8PZU/RsHPuAcnZzB4b+yZu8wV7AEZqhkZrWXH9lNjDK 4DYOHQbfQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXhUC-00085B-D3; Thu, 21 Nov 2019 08:06:44 +0000 Date: Thu, 21 Nov 2019 00:06:44 -0800 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML , "Kirill A . Shutemov" Subject: Re: [PATCH v7 01/24] mm/gup: pass flags arg to __gup_device_* functions Message-ID: <20191121080644.GA30991@infradead.org> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-2-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121071354.456618-2-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Nov 20, 2019 at 11:13:31PM -0800, John Hubbard wrote: > A subsequent patch requires access to gup flags, so > pass the flags argument through to the __gup_device_* > functions. Looks fine, but why not fold this into the patch using the flags. Also you can use up your full 73 chars per line in the commit log.