From: Alex Williamson <alex.williamson@redhat.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Jiang Yi <giangyi@amazon.com>,
kvm@vger.kernel.org, adulea@amazon.de, jschoenh@amazon.de,
cohuck@redhat.com, "Suthikulpanit,
Suravee" <suravee.suthikulpanit@amd.com>,
"Singh, Brijesh" <brijesh.singh@amd.com>,
"Lendacky, Thomas" <thomas.lendacky@amd.com>,
"Raj, Ashok" <ashok.raj@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Paul Mackerras <paulus@ozlabs.org>,
Michael Ellerman <michael@ellerman.id.au>
Subject: Re: [PATCH] vfio: call irq_bypass_unregister_producer() before freeing irq
Date: Mon, 2 Dec 2019 16:14:01 -0700 [thread overview]
Message-ID: <20191202161401.7e532e34@x1.home> (raw)
In-Reply-To: <86sgm9yye9.wl-maz@kernel.org>
On Wed, 27 Nov 2019 18:20:14 +0000
Marc Zyngier <maz@kernel.org> wrote:
> On Wed, 27 Nov 2019 16:49:10 +0000,
> Jiang Yi <giangyi@amazon.com> wrote:
>
> Hi Jiang,
>
> Thanks for spotting this!
>
> > Since irq_bypass_register_producer() is called after request_irq(), we
> > should do tear-down in reverse order: irq_bypass_unregister_producer()
> > then free_irq().
>
> More importantly, free_irq() is going to releases resources that can
> still be required by the del_producer callback. Notably, for arm64 and
> GICv4:
>
> free_irq(irq)
> __free_irq(irq)
> irq_domain_deactivate_irq(irq)
> its_irq_domain_deactivate()
> [unmap the VLPI from the ITS]
>
> kvm_arch_irq_bypass_del_producer(cons, prod)
> kvm_vgic_v4_unset_forwarding(kvm, irq, ...)
> its_unmap_vlpi(irq)
> [Unmap the VLPI from the ITS (again), remap the original LPI]
>
> which isn't great, and has the potential to wedge the HW. Reversing
> the two makes more sense: Unmap the VLPI, remap the LPI, and finally
> unmap the LPI. I haven't checked what it does with VT-D.
Yep, it seems a lot safer to reverse this but we need to incorporate
some of Marc's rationale above into the commit log to justify the
stable and fixes tags. Here's an attempt:
--
free_irq() may release resources required by the irqbypass
del_producer() callback. Notably on arm64 with GICv4:
free_irq(irq)
__free_irq(irq)
irq_domain_deactivate_irq(irq)
its_irq_domain_deactivate()
[unmap the VLPI from the ITS]
kvm_arch_irq_bypass_del_producer(cons, prod)
kvm_vgic_v4_unset_forwarding(kvm, irq, ...)
its_unmap_vlpi(irq)
[Unmap the VLPI from the ITS (again), remap the original LPI]
This has the potential to wedge hardware. Re-order to free the IRQ
after unregistering the irqbypass producer, which also provides the
proper mirror of setup ordering.
--
Cc'ing some usual suspects from AMD, Intel, and Power where the
kvm_arch_irq_bypass_del_producer() callback is also implemented.
Thanks,
Alex
> > Signed-off-by: Jiang Yi <giangyi@amazon.com>
> > ---
> > drivers/vfio/pci/vfio_pci_intrs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c
> > index 3fa3f728fb39..2056f3f85f59 100644
> > --- a/drivers/vfio/pci/vfio_pci_intrs.c
> > +++ b/drivers/vfio/pci/vfio_pci_intrs.c
> > @@ -289,18 +289,18 @@ static int vfio_msi_set_vector_signal(struct vfio_pci_device *vdev,
> > int irq, ret;
> >
> > if (vector < 0 || vector >= vdev->num_ctx)
> > return -EINVAL;
> >
> > irq = pci_irq_vector(pdev, vector);
> >
> > if (vdev->ctx[vector].trigger) {
> > - free_irq(irq, vdev->ctx[vector].trigger);
> > irq_bypass_unregister_producer(&vdev->ctx[vector].producer);
> > + free_irq(irq, vdev->ctx[vector].trigger);
> > kfree(vdev->ctx[vector].name);
> > eventfd_ctx_put(vdev->ctx[vector].trigger);
> > vdev->ctx[vector].trigger = NULL;
> > }
> >
> > if (fd < 0)
> > return 0;
> >
> > --
> > 2.17.1
> >
> >
>
> FWIW:
>
> Cc: stable@vger.kernel.org # v4.4+
> Fixes: 6d7425f109d26 ("vfio: Register/unregister irq_bypass_producer")
> Reviewed-by: Marc Zyngier <maz@kernel.org>
>
> Thanks again,
>
> M.
>
next prev parent reply other threads:[~2019-12-02 23:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 16:49 [PATCH] vfio: call irq_bypass_unregister_producer() before freeing irq Jiang Yi
2019-11-27 18:20 ` Marc Zyngier
2019-12-02 23:14 ` Alex Williamson [this message]
2019-11-28 10:01 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202161401.7e532e34@x1.home \
--to=alex.williamson@redhat.com \
--cc=adulea@amazon.de \
--cc=ashok.raj@intel.com \
--cc=brijesh.singh@amd.com \
--cc=cohuck@redhat.com \
--cc=giangyi@amazon.com \
--cc=jschoenh@amazon.de \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michael@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).