From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095B8C43603 for ; Fri, 6 Dec 2019 20:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB4282464E for ; Fri, 6 Dec 2019 20:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfLFUrt (ORCPT ); Fri, 6 Dec 2019 15:47:49 -0500 Received: from mga03.intel.com ([134.134.136.65]:60664 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfLFUrt (ORCPT ); Fri, 6 Dec 2019 15:47:49 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2019 12:47:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,286,1571727600"; d="scan'208";a="209535429" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga008.fm.intel.com with ESMTP; 06 Dec 2019 12:47:47 -0800 Date: Fri, 6 Dec 2019 12:47:47 -0800 From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Shuah Khan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 0/3] Reanme the definitions of INTERRUPT_PENDING, NMI_PENDING and TSC_OFFSETING Message-ID: <20191206204747.GD5433@linux.intel.com> References: <20191206084526.131861-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191206084526.131861-1-xiaoyao.li@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Dec 06, 2019 at 04:45:23PM +0800, Xiaoyao Li wrote: > When reading the codes, I find the definitions of interrupt-window exiting > and nmi-window exiting don't match the names in latest intel SDM. I prefer KVM's names even though they diverge from the SDM. The "window exiting" terminology is very literal, which is desirable for the SDM because it doesn't leave any wiggle room. But for software, IMO the "event pending" terminology is preferable as it's more descriptive of the intended use of the control, e.g. KVM sets VIRTUAL_{INTR,NMI}_PENDING when it has a virtual event to inject and clears it after injecting said event.