From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, jmattson@google.com
Subject: [PATCH 4/4] kvm-unit-test: nVMX: Test GUEST_SYSENTER_ESP and GUEST_SYSENTER_EIP on vmentry of nested guests
Date: Fri, 6 Dec 2019 18:13:02 -0500 [thread overview]
Message-ID: <20191206231302.3466-5-krish.sadhukhan@oracle.com> (raw)
In-Reply-To: <20191206231302.3466-1-krish.sadhukhan@oracle.com>
According to section "Checks on Guest Control Registers, Debug Registers, and
and MSRs" in Intel SDM vol 3C, the following checks are performed on vmentry
of nested guests:
"The IA32_SYSENTER_ESP field and the IA32_SYSENTER_EIP field must each
contain a canonical address."
Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
---
x86/vmx_tests.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 5f836d4..2dbc0bf 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -7219,9 +7219,9 @@ static void test_canonical(u64 field, const char * field_name, bool host)
report_prefix_pop();
} else {
enter_guest();
- report_guest_state_test("%s",
+ report_guest_state_test("Test canonical address",
VMX_VMCALL, addr_saved,
- "GUEST_XXXXXXX");
+ field_name);
}
vmcs_write(field, NONCANONICAL);
@@ -7232,11 +7232,9 @@ static void test_canonical(u64 field, const char * field_name, bool host)
report_prefix_pop();
} else {
enter_guest_with_invalid_guest_state();
- report_guest_state_test("ENT_LOAD_PAT "
- "enabled",
+ report_guest_state_test("Test canonical address",
VMX_FAIL_STATE | VMX_ENTRY_FAILURE,
- addr_saved,
- "GUEST_PAT");
+ NONCANONICAL, field_name);
}
vmcs_write(field, addr_saved);
@@ -7247,11 +7245,9 @@ static void test_canonical(u64 field, const char * field_name, bool host)
report_prefix_pop();
} else {
enter_guest_with_invalid_guest_state();
- report_guest_state_test("ENT_LOAD_PAT "
- "enabled",
+ report_guest_state_test("Test canonical address",
VMX_FAIL_STATE | VMX_ENTRY_FAILURE,
- addr_saved,
- "GUEST_PAT");
+ NONCANONICAL, field_name);
}
}
}
@@ -7450,6 +7446,13 @@ static void vmx_guest_state_area_test(void)
vmx_set_test_stage(1);
test_set_guest(guest_state_test_main);
+ /*
+ * The IA32_SYSENTER_ESP field and the IA32_SYSENTER_EIP field
+ * must each contain a canonical address.
+ */
+ test_canonical(GUEST_SYSENTER_ESP, "GUEST_SYSENTER_ESP", false);
+ test_canonical(GUEST_SYSENTER_EIP, "GUEST_SYSENTER_EIP", false);
+
test_load_guest_pat();
test_guest_efer();
test_load_guest_perf_global_ctrl();
--
2.20.1
prev parent reply other threads:[~2019-12-06 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 23:12 [PATCH 0/4] KVM: nVMX: Check GUEST_SYSENTER_ESP and GUEST_SYSENTER_EIP on vmentry of nested guests Krish Sadhukhan
2019-12-06 23:12 ` [PATCH 1/4] " Krish Sadhukhan
2019-12-10 17:30 ` Paolo Bonzini
2019-12-10 17:57 ` Jim Mattson
2019-12-10 19:35 ` Krish Sadhukhan
2019-12-10 19:48 ` Jim Mattson
2019-12-10 20:29 ` Krish Sadhukhan
2019-12-10 20:36 ` Paolo Bonzini
2019-12-06 23:13 ` [PATCH 2/4] kvm-unit-test: nVMX: Modify test_canonical() to process guest fields also Krish Sadhukhan
2019-12-06 23:13 ` [PATCH 3/4] kvm-unit-test: nVMX: Remove test_sysenter_field() and use test_canonical() instead Krish Sadhukhan
2019-12-06 23:13 ` Krish Sadhukhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206231302.3466-5-krish.sadhukhan@oracle.com \
--to=krish.sadhukhan@oracle.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).