* [PATCH] vfio/mdev: make create attribute static
@ 2019-12-18 12:31 Ben Dooks (Codethink)
2019-12-19 20:00 ` Cornelia Huck
2020-01-10 16:02 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-12-18 12:31 UTC (permalink / raw)
To: ben.dooks
Cc: Kirti Wankhede, Alex Williamson, Cornelia Huck, kvm, linux-kernel
The create attribute is not exported, so make it
static to avoid the following sparse warning:
drivers/vfio/mdev/mdev_sysfs.c:77:1: warning: symbol 'mdev_type_attr_create' was not declared. Should it be static?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/vfio/mdev/mdev_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index 7570c7602ab4..8ad14e5c02bf 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -74,7 +74,7 @@ static ssize_t create_store(struct kobject *kobj, struct device *dev,
return count;
}
-MDEV_TYPE_ATTR_WO(create);
+static MDEV_TYPE_ATTR_WO(create);
static void mdev_type_release(struct kobject *kobj)
{
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/mdev: make create attribute static
2019-12-18 12:31 [PATCH] vfio/mdev: make create attribute static Ben Dooks (Codethink)
@ 2019-12-19 20:00 ` Cornelia Huck
2020-01-10 16:02 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2019-12-19 20:00 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Kirti Wankhede, Alex Williamson, kvm, linux-kernel
On Wed, 18 Dec 2019 12:31:19 +0000
"Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> wrote:
> The create attribute is not exported, so make it
> static to avoid the following sparse warning:
>
> drivers/vfio/mdev/mdev_sysfs.c:77:1: warning: symbol 'mdev_type_attr_create' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: kvm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index 7570c7602ab4..8ad14e5c02bf 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -74,7 +74,7 @@ static ssize_t create_store(struct kobject *kobj, struct device *dev,
> return count;
> }
>
> -MDEV_TYPE_ATTR_WO(create);
> +static MDEV_TYPE_ATTR_WO(create);
>
> static void mdev_type_release(struct kobject *kobj)
> {
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/mdev: make create attribute static
2019-12-18 12:31 [PATCH] vfio/mdev: make create attribute static Ben Dooks (Codethink)
2019-12-19 20:00 ` Cornelia Huck
@ 2020-01-10 16:02 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2020-01-10 16:02 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: Kirti Wankhede, Cornelia Huck, kvm, linux-kernel
On Wed, 18 Dec 2019 12:31:19 +0000
"Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk> wrote:
> The create attribute is not exported, so make it
> static to avoid the following sparse warning:
>
> drivers/vfio/mdev/mdev_sysfs.c:77:1: warning: symbol 'mdev_type_attr_create' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: kvm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/vfio/mdev/mdev_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
> index 7570c7602ab4..8ad14e5c02bf 100644
> --- a/drivers/vfio/mdev/mdev_sysfs.c
> +++ b/drivers/vfio/mdev/mdev_sysfs.c
> @@ -74,7 +74,7 @@ static ssize_t create_store(struct kobject *kobj, struct device *dev,
> return count;
> }
>
> -MDEV_TYPE_ATTR_WO(create);
> +static MDEV_TYPE_ATTR_WO(create);
>
> static void mdev_type_release(struct kobject *kobj)
> {
Applied to vfio next branch for v5.6 with Connie's R-b. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 12:31 [PATCH] vfio/mdev: make create attribute static Ben Dooks (Codethink)
2019-12-19 20:00 ` Cornelia Huck
2020-01-10 16:02 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).