From: Peter Xu <peterx@redhat.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
peterx@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Christophe de Dinechin <dinechin@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: [PATCH v2 05/17] KVM: Add build-time error check on kvm_run size
Date: Fri, 20 Dec 2019 16:01:35 -0500 [thread overview]
Message-ID: <20191220210147.49617-6-peterx@redhat.com> (raw)
In-Reply-To: <20191220210147.49617-1-peterx@redhat.com>
It's already going to reach 2400 Bytes (which is over half of page
size on 4K page archs), so maybe it's good to have this build-time
check in case it overflows when adding new fields.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
virt/kvm/kvm_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index cea4b8dd4ac9..c80a363831ae 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -338,6 +338,7 @@ int kvm_vcpu_init(struct kvm_vcpu *vcpu, struct kvm *kvm, unsigned id)
vcpu->pre_pcpu = -1;
INIT_LIST_HEAD(&vcpu->blocked_vcpu_list);
+ BUILD_BUG_ON(sizeof(struct kvm_run) > PAGE_SIZE);
page = alloc_page(GFP_KERNEL | __GFP_ZERO);
if (!page) {
r = -ENOMEM;
--
2.24.1
next prev parent reply other threads:[~2019-12-20 21:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 21:01 [PATCH v2 00/17] KVM: Dirty ring interface Peter Xu
2019-12-20 21:01 ` [PATCH v2 01/17] KVM: Remove kvm_read_guest_atomic() Peter Xu
2019-12-20 21:01 ` [PATCH v2 02/17] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2019-12-20 21:01 ` [PATCH v2 03/17] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2019-12-20 21:01 ` [PATCH v2 04/17] KVM: Cache as_id in kvm_memory_slot Peter Xu
2019-12-20 21:01 ` Peter Xu [this message]
2019-12-20 21:01 ` [PATCH v2 06/17] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2019-12-20 21:01 ` [PATCH v2 07/17] KVM: Move running VCPU from ARM to common code Peter Xu
2019-12-20 21:01 ` [PATCH v2 08/17] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2019-12-20 21:01 ` [PATCH v2 09/17] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2019-12-20 21:03 [PATCH v2 00/17] KVM: Dirty ring interface Peter Xu
2019-12-20 21:03 ` [PATCH v2 05/17] KVM: Add build-time error check on kvm_run size Peter Xu
2019-12-20 21:16 [PATCH v2 00/17] KVM: Dirty ring interface Peter Xu
2019-12-20 21:16 ` [PATCH v2 05/17] KVM: Add build-time error check on kvm_run size Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220210147.49617-6-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).