From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
david@redhat.com, borntraeger@de.ibm.com, frankja@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v5 3/4] s390x: lib: add SPX and STPX instruction wrapper
Date: Thu, 9 Jan 2020 12:36:46 +0100 [thread overview]
Message-ID: <20200109123646.6b79194e@p-imbrenda> (raw)
In-Reply-To: <ff1041f2-0262-ed89-4c5e-386f69d21cd0@redhat.com>
On Wed, 8 Jan 2020 19:58:27 +0100
Thomas Huth <thuth@redhat.com> wrote:
> On 08/01/2020 17.13, Claudio Imbrenda wrote:
> > Add a wrapper for the SET PREFIX and STORE PREFIX instructions, and
> > use it instead of using inline assembly everywhere.
>
> Either some hunks are missing in this patch, or you should update the
> patch description and remove the second part of the sentence ? ... at
> least I did not spot the changes where you "use it instead of using
> inline assembly everywhere".
oops sorry, the description is a little misleading. I meant
everywhere in the specific unit test, not everywhere in the whole
source tree.
I should either change the description or actually patch the remaining
users of inline assembly to use the wrappers instead. (any preference?)
next prev parent reply other threads:[~2020-01-09 11:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 16:13 [kvm-unit-tests PATCH v5 0/4] s390x: SCLP Unit test Claudio Imbrenda
2020-01-08 16:13 ` [kvm-unit-tests PATCH v5 1/4] s390x: export sclp_setup_int Claudio Imbrenda
2020-01-08 16:13 ` [kvm-unit-tests PATCH v5 2/4] s390x: sclp: add service call instruction wrapper Claudio Imbrenda
2020-01-08 16:13 ` [kvm-unit-tests PATCH v5 3/4] s390x: lib: add SPX and STPX " Claudio Imbrenda
2020-01-08 18:58 ` Thomas Huth
2020-01-09 11:36 ` Claudio Imbrenda [this message]
2020-01-09 12:55 ` Thomas Huth
2020-01-08 16:13 ` [kvm-unit-tests PATCH v5 4/4] s390x: SCLP unit test Claudio Imbrenda
2020-01-09 12:42 ` Thomas Huth
2020-01-09 13:29 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109123646.6b79194e@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).